Issue24729
Created on 2015-07-26 15:20 by jaraco, last changed 2015-07-29 18:31 by jaraco. This issue is now closed.
| Files | ||||
|---|---|---|---|---|
| File name | Uploaded | Description | Edit | |
| issue24729.patch | acucci, 2015-07-26 17:08 | Patch | review | |
| issue24729_v2.patch | acucci, 2015-07-28 18:06 | Patch v2 | review | |
| issue24729_v3.patch | acucci, 2015-07-28 19:01 | Patch v3 | review | |
| issue24729_v4.patch | acucci, 2015-07-29 17:55 | Patch v4 | review | |
| issue24729_v4.patch | acucci, 2015-07-29 17:58 | review | ||
| Messages (11) | |||
|---|---|---|---|
| msg247433 - (view) | Author: Jason R. Coombs (jaraco) * | Date: 2015-07-26 15:20 | |
In Doc/tutorial/inputoutput.rst, the docs state this about opening a file: Normally, files are opened in :dfn:`text mode`, that means, you read and write strings from and to the file, which are encoded in a specific encoding (the default being UTF-8). That statement is directly contradicted by the docs for open (Doc/library/functions.rst) which indicate: In text mode, if encoding is not specified the encoding used is platform dependent: locale.getpreferredencoding(False) is called to get the current locale encoding. The implementation matches the latter indication. |
|||
| msg247440 - (view) | Author: Alessandro Cucci (acucci) * | Date: 2015-07-26 17:08 | |
corrected |
|||
| msg247478 - (view) | Author: R. David Murray (r.david.murray) * | Date: 2015-07-27 18:31 | |
Hmm. It's a tutorial. It would probably be better to just say "the default is platform dependent" with a link to the open docs. |
|||
| msg247534 - (view) | Author: Alessandro Cucci (acucci) * | Date: 2015-07-28 18:06 | |
@r.david.murray: just like that? (see patch v2) |
|||
| msg247536 - (view) | Author: R. David Murray (r.david.murray) * | Date: 2015-07-28 18:22 | |
A direct link to open would be better ("see :func:`~functions.open`" should do it, I think).
|
|||
| msg247539 - (view) | Author: Alessandro Cucci (acucci) * | Date: 2015-07-28 19:01 | |
tried again :) |
|||
| msg247540 - (view) | Author: R. David Murray (r.david.murray) * | Date: 2015-07-28 19:38 | |
Looks good to me assuming it renders correctly. |
|||
| msg247546 - (view) | Author: Carol Willing (willingc) * | Date: 2015-07-28 22:14 | |
@acucci and R. David Murray: I've run the patch locally, and all renders well except for one link. @acucci: I believe that the direct link to the `open()` command should be ... "see :func:`open` " An example exists at the beginning of the section containing this line. The command in the current patch renders as plain text and not a link. If you can fix this small issue, the patch should be ready to merge (pending R David Murray's agreement). Thanks! |
|||
| msg247589 - (view) | Author: Alessandro Cucci (acucci) * | Date: 2015-07-29 17:55 | |
ok, this time I tested the render myself and seems ok. For rendering I used sphinx. Sorry if I didn't try the final result in the first time, but I've never had the chance to use rst files before. |
|||
| msg247597 - (view) | Author: Roundup Robot (python-dev) | Date: 2015-07-29 18:30 | |
New changeset c9e78d91d588 by Alessandro Cucci in branch '3.4': Issue #24729: Update tutorial to match implementation. https://hg.python.org/cpython/rev/c9e78d91d588 New changeset 20084be60761 by Jason R. Coombs in branch '3.4': Issue #24729: Correct reference to open function. https://hg.python.org/cpython/rev/20084be60761 New changeset 575e60ed7cb8 by Jason R. Coombs in branch '3.5': Merge with 3.4 for Issue #24729 https://hg.python.org/cpython/rev/575e60ed7cb8 New changeset 47330144debd by Jason R. Coombs in branch 'default': Merge with 3.5 for Issue #24729 https://hg.python.org/cpython/rev/47330144debd |
|||
| msg247598 - (view) | Author: Jason R. Coombs (jaraco) * | Date: 2015-07-29 18:31 | |
Thanks for working through this Alessandro. I've applied your v3 patch and added a subsequent commit 20084be60761 to correct the open reference. |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2015-07-29 18:31:19 | jaraco | set | status: open -> closed resolution: fixed messages: + msg247598 |
| 2015-07-29 18:30:07 | python-dev | set | nosy:
+ python-dev messages: + msg247597 |
| 2015-07-29 17:58:27 | acucci | set | files: + issue24729_v4.patch |
| 2015-07-29 17:55:32 | acucci | set | files:
+ issue24729_v4.patch messages: + msg247589 |
| 2015-07-28 22:14:50 | willingc | set | nosy:
+ willingc messages:
+ msg247546 |
| 2015-07-28 19:38:19 | r.david.murray | set | messages:
+ msg247540 stage: commit review |
| 2015-07-28 19:01:59 | acucci | set | files:
+ issue24729_v3.patch messages: + msg247539 |
| 2015-07-28 18:22:43 | r.david.murray | set | messages: + msg247536 |
| 2015-07-28 18:06:27 | acucci | set | files:
+ issue24729_v2.patch messages: + msg247534 |
| 2015-07-27 18:31:08 | r.david.murray | set | nosy:
+ r.david.murray messages: + msg247478 |
| 2015-07-26 17:08:42 | acucci | set | files:
+ issue24729.patch nosy:
+ acucci keywords: + patch |
| 2015-07-26 15:20:36 | jaraco | set | keywords: + easy |
| 2015-07-26 15:20:18 | jaraco | create | |