Issue26316
Created on 2016-02-09 02:32 by martin.panter, last changed 2016-02-14 04:35 by martin.panter. This issue is now closed.
| Messages (5) | |||
|---|---|---|---|
| msg259908 - (view) | Author: Martin Panter (martin.panter) * | Date: 2016-02-09 02:32 | |
The curly bracket separator is assigned to “curl”, but then the previous “curly” variable is tested: https://hg.python.org/cpython/annotate/3.5/Tools/clinic/clinic.py#l202 name, curl, trailing = trailing.partition('}') if not curly or name not in kwargs: ... I presume the fix is to assign to “curly”, but I haven’t had a chance to figure out how to test it yet. |
|||
| msg259912 - (view) | Author: Larry Hastings (larry) * | Date: 2016-02-09 04:12 | |
Yeah, change "curl" to "curly". If you commit the fix without a test case I'd forgive you. Or I can do it if that makes you nervous. |
|||
| msg260050 - (view) | Author: STINNER Victor (vstinner) * | Date: 2016-02-10 22:30 | |
Go ahead. |
|||
| msg260260 - (view) | Author: Roundup Robot (python-dev) | Date: 2016-02-14 03:25 | |
New changeset aec2eae8933e by Martin Panter in branch '3.5': Issue #26316: Fix variable name typo in Argument Clinic https://hg.python.org/cpython/rev/aec2eae8933e New changeset 6c122e4e1cb2 by Martin Panter in branch 'default': Issue #26316: Merge Arg Clinic fix from 3.5 https://hg.python.org/cpython/rev/6c122e4e1cb2 |
|||
| msg260262 - (view) | Author: Martin Panter (martin.panter) * | Date: 2016-02-14 04:35 | |
I did look into testing, but I gave up. :) The test file doesn’t even import. I got the following error (without exception or traceback), cause by the line that reads “c = clinic.Clinic(language='C')”: $ (cd Tools/clinic/ && ../../python clinic_test.py) Error: Destination does not exist: 'file' [Exit 255] |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2016-02-14 04:35:14 | martin.panter | set | status: open -> closed resolution: fixed messages: + msg260262 stage: needs patch -> resolved |
| 2016-02-14 03:25:47 | python-dev | set | nosy:
+ python-dev messages: + msg260260 |
| 2016-02-12 19:30:11 | terry.reedy | set | title: Probable typo in Arg Clinic’s linear_format() -> Probable typo in Arg Clinic's linear_format() |
| 2016-02-10 22:30:22 | vstinner | set | nosy:
+ vstinner messages: + msg260050 |
| 2016-02-09 04:12:41 | larry | set | messages: + msg259912 |
| 2016-02-09 02:32:33 | martin.panter | create | |