Created on 2016-06-29 18:27 by serhiy.storchaka, last changed 2016-06-30 07:36 by serhiy.storchaka. This issue is now closed.
| Files | ||||
|---|---|---|---|---|
| File name | Uploaded | Description | Edit | |
| importbench.patch | serhiy.storchaka, 2016-06-29 20:49 | review | ||
| Messages (7) | |||
|---|---|---|---|
| msg269539 - (view) | Author: Serhiy Storchaka (serhiy.storchaka) * | Date: 2016-06-29 18:27 | |
$ ./python Tools/importbench/importbench.py Traceback (most recent call last): File "Tools/importbench/importbench.py", line 8, in <module> from test.test_importlib.source import util as source_util ImportError: cannot import name 'util' |
|||
| msg269541 - (view) | Author: Brett Cannon (brett.cannon) * | Date: 2016-06-29 18:38 | |
If you don't have any use for it I say just delete the benchmark. |
|||
| msg269543 - (view) | Author: Serhiy Storchaka (serhiy.storchaka) * | Date: 2016-06-29 18:45 | |
Just now I'm writing a patch for optimizing __import__. Maybe importbench would be helpful. |
|||
| msg269552 - (view) | Author: Brett Cannon (brett.cannon) * | Date: 2016-06-29 19:50 | |
Feel free to do whatever you need/want to with the benchmark. I originally created it when switching __import__ to importlib to prove that it didn't impact performance. |
|||
| msg269553 - (view) | Author: Serhiy Storchaka (serhiy.storchaka) * | Date: 2016-06-29 20:49 | |
Following patch seems fixes importbench. |
|||
| msg269557 - (view) | Author: Brett Cannon (brett.cannon) * | Date: 2016-06-29 22:02 | |
I don't see anything obviously wrong with it. |
|||
| msg269561 - (view) | Author: Roundup Robot (python-dev) | Date: 2016-06-30 07:35 | |
New changeset ba4548916f05 by Serhiy Storchaka in branch '3.5': Issue #27418: Fixed Tools/importbench/importbench.py. https://hg.python.org/cpython/rev/ba4548916f05 New changeset c2e898813409 by Serhiy Storchaka in branch 'default': Issue #27418: Fixed Tools/importbench/importbench.py. https://hg.python.org/cpython/rev/c2e898813409 |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2016-06-30 07:36:02 | serhiy.storchaka | set | status: open -> closed resolution: fixed stage: patch review -> resolved |
| 2016-06-30 07:35:12 | python-dev | set | nosy:
+ python-dev messages: + msg269561 |
| 2016-06-29 22:02:05 | brett.cannon | set | messages: + msg269557 |
| 2016-06-29 20:49:48 | serhiy.storchaka | set | files:
+ importbench.patch keywords: + patch messages: + msg269553 stage: patch review |
| 2016-06-29 19:50:59 | brett.cannon | set | messages: + msg269552 |
| 2016-06-29 18:45:48 | serhiy.storchaka | set | messages: + msg269543 |
| 2016-06-29 18:38:34 | brett.cannon | set | messages: + msg269541 |
| 2016-06-29 18:27:40 | serhiy.storchaka | create | |