Created on 2018-05-26 19:52 by ned.deily, last changed 2018-05-26 21:59 by ned.deily. This issue is now closed.
| Pull Requests | |||
|---|---|---|---|
| URL | Status | Linked | Edit |
| PR 7134 | merged | ned.deily, 2018-05-26 20:11 | |
| PR 7135 | merged | miss-islington, 2018-05-26 20:32 | |
| PR 7136 | merged | miss-islington, 2018-05-26 20:32 | |
| Messages (5) | |||
|---|---|---|---|
| msg317763 - (view) | Author: Ned Deily (ned.deily) * | Date: 2018-05-26 19:52 | |
Seen on some of the various FreeBSD buildbots: ====================================================================== ERROR: test_posix_fallocate (test.test_posix.PosixTester) ---------------------------------------------------------------------- Traceback (most recent call last): File "/usr/home/buildbot/python/3.7.koobs-freebsd-current/build/Lib/test/test_posix.py", line 342, in test_posix_fallocate posix.posix_fallocate(fd, 0, 10) OSError: [Errno 22] Invalid argument ---------------------------------------------------------------------- As discussed in Issue31106 msg312453 and successors, the failure is due to posix_fallocate not being implemented on ZFS and the difficulty of determining in a platform-independent way what kind of file system a given file resides on. The test already ignores EINVAL ("Invalid argument") errors when run on Solaris-type platforms due to the common use of ZFS there. In lieu of a more precise test for fs type, we should also ignore EINVAL errors in this test when run on *BSD platforms. Also, rather than silently ignoring the error, it may be better to use a SkipTest message. |
|||
| msg317764 - (view) | Author: Ned Deily (ned.deily) * | Date: 2018-05-26 20:30 | |
New changeset 09c4a7dee2eb39b515e5f499f184257cdbe9cb42 by Ned Deily in branch 'master': bpo-33655: Also ignore test_posix_fallocate failures on BSD platforms (GH-7134) https://github.com/python/cpython/commit/09c4a7dee2eb39b515e5f499f184257cdbe9cb42 |
|||
| msg317769 - (view) | Author: miss-islington (miss-islington) | Date: 2018-05-26 21:57 | |
New changeset 96fb828da305b18336b8d74b14f479c4f286cf7b by Miss Islington (bot) in branch '3.7': bpo-33655: Also ignore test_posix_fallocate failures on BSD platforms (GH-7134) https://github.com/python/cpython/commit/96fb828da305b18336b8d74b14f479c4f286cf7b |
|||
| msg317770 - (view) | Author: miss-islington (miss-islington) | Date: 2018-05-26 21:58 | |
New changeset ae27dee0f8f364f0bbb170d918a28b87cd0753d9 by Miss Islington (bot) in branch '3.6': bpo-33655: Also ignore test_posix_fallocate failures on BSD platforms (GH-7134) https://github.com/python/cpython/commit/ae27dee0f8f364f0bbb170d918a28b87cd0753d9 |
|||
| msg317771 - (view) | Author: Ned Deily (ned.deily) * | Date: 2018-05-26 21:59 | |
Fix merged for 3.7.0 and 3.6.6. |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2018-05-26 21:59:11 | ned.deily | set | status: open -> closed resolution: fixed messages: + msg317771 stage: patch review -> resolved |
| 2018-05-26 21:58:02 | miss-islington | set | messages: + msg317770 |
| 2018-05-26 21:57:04 | miss-islington | set | nosy:
+ miss-islington messages: + msg317769 |
| 2018-05-26 20:32:58 | miss-islington | set | pull_requests: + pull_request6770 |
| 2018-05-26 20:32:10 | miss-islington | set | pull_requests: + pull_request6769 |
| 2018-05-26 20:30:49 | ned.deily | set | messages: + msg317764 |
| 2018-05-26 20:11:25 | ned.deily | set | keywords:
+ patch pull_requests: + pull_request6768 |
| 2018-05-26 19:52:51 | ned.deily | create | |