[proxy] web.archive.org — ← back | site home | direct (HTTPS) ↗ | proxy home | ◑ dark◐ light
classification
Title: ctypes.find_library processing - missing parenthesis prevents subprocess from getting a returncode
Type: behavior Stage: resolved
Components: Library (Lib), Tests Versions: Python 3.8, Python 3.7
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: Nosy List: Mariatta, Michael.Felt, miss-islington
Priority: normal Keywords: patch

Created on 2018-08-31 19:24 by Michael.Felt, last changed 2018-09-01 02:46 by miss-islington. This issue is now closed.

Pull Requests
URL Status Linked Edit
PR 9017 merged Michael.Felt, 2018-08-31 19:34
PR 9023 merged miss-islington, 2018-09-01 02:31
Messages (4)
msg324441 - (view) Author: Michael Felt (Michael.Felt) * Date: 2018-08-31 19:24 
With AIX I have seen the following messages repeatedly:

root@x066:[/data/prj/python/python3-3.8]./python ../git/*Lib/ctypes/test/test_loading.py
/data/prj/python/git/python3-3.8/Lib/subprocess.py:852: ResourceWarning: subprocess 11796734 is still running
  ResourceWarning, source=self)
/data/prj/python/git/python3-3.8/Lib/subprocess.py:852: ResourceWarning: subprocess 11796480 is still running
  ResourceWarning, source=self)

There is python2 to python3 missed change typo that is preventing the returncode from ever being determined

diff --git a/Lib/ctypes/_aix.py b/Lib/ctypes/_aix.py
index 463f60a284..190cac6507 100644
--- a/Lib/ctypes/_aix.py
+++ b/Lib/ctypes/_aix.py
@@ -115,7 +115,7 @@ def get_ld_headers(file):
         else:
             break
     p.stdout.close()
-    p.wait
+    p.wait()
     return ldr_headers

 def get_shared(ld_headers):

PR will be posted.
msg324457 - (view) Author: Mariatta (Mariatta) * Date: 2018-09-01 02:31 
New changeset 172a71f19bb5e9624651850b315f403c460b9699 by Mariatta (Michael Felt) in branch 'master':
bpo-34558: Add missing parentheses in _aix.py (GH-9017)
https://github.com/python/cpython/commit/172a71f19bb5e9624651850b315f403c460b9699
msg324458 - (view) Author: Mariatta (Mariatta) * Date: 2018-09-01 02:36 
Thanks!
msg324459 - (view) Author: miss-islington (miss-islington) Date: 2018-09-01 02:46 
New changeset 89c9043ee09d89c99f70e61d8fc0ba45e255b055 by Miss Islington (bot) in branch '3.7':
bpo-34558: Add missing parentheses in _aix.py (GH-9017)
https://github.com/python/cpython/commit/89c9043ee09d89c99f70e61d8fc0ba45e255b055
History
Date User Action Args
2018-09-01 02:46:36miss-islingtonsetnosy: + miss-islington
messages: + msg324459
2018-09-01 02:36:46Mariattasetstatus: open -> closed
resolution: fixed
messages: + msg324458

stage: patch review -> resolved
2018-09-01 02:31:40miss-islingtonsetpull_requests: + pull_request8491
2018-09-01 02:31:11Mariattasetnosy: + Mariatta
messages: + msg324457
2018-08-31 19:34:18Michael.Feltsetkeywords: + patch
stage: patch review
pull_requests: + pull_request8485
2018-08-31 19:24:42Michael.Feltcreate