Issue 34824: _ssl.c: Possible null pointer dereference [proxy]

The Wayback Machine - https://web.archive.org/web/20210306010739/https://bugs.python.org/issue34824

Issue34824

classification

Title:	_ssl.c: Possible null pointer dereference
Type:		Stage:	resolved
Components:	Extension Modules, SSL	Versions:	Python 3.8, Python 3.7, Python 3.6

process

Status:	closed	Resolution:	fixed
Dependencies:		Superseder:
Assigned To:	christian.heimes	Nosy List:	ZackerySpytz, christian.heimes, miss-islington, serhiy.storchaka, vstinner, yselivanov
Priority:	normal	Keywords:	patch

Created on 2018-09-27 17:07 by ZackerySpytz, last changed 2018-10-19 23:16 by vstinner. This issue is now closed.

Messages (6)
msg326573 - (view)	Author: Zackery Spytz (ZackerySpytz) *	Date: 2018-09-27 17:07
If _PyBytes_Resize() fails in _ssl_MemoryBIO_read_impl(), Py_DECREF() will be called on a null pointer.
msg326814 - (view)	Author: Serhiy Storchaka (serhiy.storchaka) *	Date: 2018-10-01 16:29
Good catch, but there is more than one error here.
msg327255 - (view)	Author: miss-islington (miss-islington)	Date: 2018-10-06 17:41
New changeset 365ad2ead5bbaf7a3b18648ffa36e819559d3f75 by Miss Islington (bot) (Zackery Spytz) in branch 'master': bpo-34824: Fix a possible NULL pointer dereference in _ssl.c (GH-9606) https://github.com/python/cpython/commit/365ad2ead5bbaf7a3b18648ffa36e819559d3f75
msg328076 - (view)	Author: STINNER Victor (vstinner) *	Date: 2018-10-19 23:14
New changeset 4ec9f64e07c8f397ad6699f8b99843846c219588 by Victor Stinner (Miss Islington (bot)) in branch '3.7': bpo-34824: Fix a possible NULL pointer dereference in _ssl.c (GH-9606) (GH-9743) https://github.com/python/cpython/commit/4ec9f64e07c8f397ad6699f8b99843846c219588
msg328077 - (view)	Author: STINNER Victor (vstinner) *	Date: 2018-10-19 23:14
New changeset d92816de667169fbd54a3442705bc07286e8c69d by Victor Stinner (Miss Islington (bot)) in branch '3.6': bpo-34824: Fix a possible NULL pointer dereference in _ssl.c (GH-9606) (GH-9744) https://github.com/python/cpython/commit/d92816de667169fbd54a3442705bc07286e8c69d
msg328078 - (view)	Author: STINNER Victor (vstinner) *	Date: 2018-10-19 23:16
Thanks Zackery Spytz for the report and the fix!

History
Date	User	Action	Args
2018-10-19 23:16:33	vstinner	set	status: open -> closed resolution: fixed messages: + msg328078 stage: patch review -> resolved
2018-10-19 23:14:52	vstinner	set	messages: + msg328077
2018-10-19 23:14:47	vstinner	set	nosy: + vstinner messages: + msg328076
2018-10-06 17:42:09	miss-islington	set	pull_requests: + pull_request9132
2018-10-06 17:42:03	miss-islington	set	pull_requests: + pull_request9131
2018-10-06 17:41:51	miss-islington	set	nosy: + miss-islington messages: + msg327255
2018-10-01 16:29:12	serhiy.storchaka	set	nosy: + serhiy.storchaka messages: + msg326814
2018-09-27 17:11:30	ZackerySpytz	set	keywords: + patch stage: patch review pull_requests: + pull_request9003
2018-09-27 17:09:12	yselivanov	set	nosy: + yselivanov
2018-09-27 17:07:57	ZackerySpytz	create