Issue 35045: test_min_max_version (test.test_ssl.ContextTests) fails on Fedora 29+ and openssl 1.1.1

There is an Python test that checks the minimum TLS version - test_min_max_version (test.test_ssl.ContextTests).

Fedora 29+ sets TLSv1 as explicit minimum version. Python's test suite assumes that the minimum protocol version is set to a magic marker.


FAIL: test_min_max_version (test.test_ssl.ContextTests)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/builddir/build/BUILD/Python-3.7.0/Lib/test/test_ssl.py", line 1084, in test_min_max_version
    ctx.minimum_version, ssl.TLSVersion.MINIMUM_SUPPORTED
AssertionError: <TLSVersion.TLSv1: 769> != <TLSVersion.MINIMUM_SUPPORTED: -2>


We currently workaround the problem by setting:

    export OPENSSL_CONF=/non-existing-file

I closed #35076 as a duplicate of this.  The distribution was not specified.  The version is 3.7.1 plus additional patches.  A build log is attached.

The OP for #35076 emailed me that the distribution is obarun, based on ArchLinux. with LibreSSL not officialy supported, but for the moment a personal work.

By the way LibreSSL isn't offically supported by Python, either. It just happens to work most of the time. I regard LibreSSL as not supported, because no core developer or regular contributor has shown any interest to work on LibreSSL support. OpenSSL is used on almost all platforms (most Linux distros, Windows, macOS, FreeBSD) any way.

New changeset 34de2d312b3687994ddbc29adb66e88f672034c7 by Victor Stinner (Christian Heimes) in branch 'master':
bpo-35045: Accept TLSv1 default in min max test (GH-11510)
https://github.com/python/cpython/commit/34de2d312b3687994ddbc29adb66e88f672034c7

Python 2.7 is not affected: test_ssl doesn't test minimum_version.

New changeset 6ca7183b3549d3eaa8a0c3b73255eeac24d7974d by Miss Islington (bot) in branch '3.7':
bpo-35045: Accept TLSv1 default in min max test (GH-11510)
https://github.com/python/cpython/commit/6ca7183b3549d3eaa8a0c3b73255eeac24d7974d

Thanks Christian. I merged your PR.

I like the simplicity of your fix ;-)

keywords: patch, patch, patch
resolution: fixed
stage: patch review -> resolved

messages: + msg333975