Issue 39388: IDLE: Changes to keybindings aren't reverted on cancel [proxy]

The Wayback Machine - https://web.archive.org/web/20210119121452/https://bugs.python.org/issue39388

Issue39388

classification

Title:	IDLE: Changes to keybindings aren't reverted on cancel
Type:	enhancement	Stage:	resolved
Components:	IDLE	Versions:	Python 3.9, Python 3.8, Python 3.7

process

Status:	closed	Resolution:	fixed
Dependencies:		Superseder:
Assigned To:	terry.reedy	Nosy List:	cheryl.sabella, miss-islington, terry.reedy
Priority:	normal	Keywords:	patch

Created on 2020-01-19 17:26 by cheryl.sabella, last changed 2020-01-25 11:37 by terry.reedy. This issue is now closed.

Pull Requests
URL	Status	Linked	Edit
PR 18068	merged	cheryl.sabella, 2020-01-19 17:29
PR 18178	merged	miss-islington, 2020-01-25 09:01
PR 18179	merged	miss-islington, 2020-01-25 09:01

Messages (5)
msg360262 - (view)	Author: Cheryl Sabella (cheryl.sabella) *	Date: 2020-01-19 17:26
In https://bugs.python.org/issue35598#msg332634, Terry mentioned a bug when updating the configuration of a key, but then cancelling out of configdialog. > Change a key binding. Cancel. Re-open config dialog. Try to change back. It says original binding is in use -- which it is if one closes IDLE and reopens, or opens a different instance. It seems that cancel is not properly undoing the temporary change.
msg360667 - (view)	Author: Terry J. Reedy (terry.reedy) *	Date: 2020-01-25 02:19
Thank you for the reminder. There must be other changes not being cancelled, but I will finish this fix instead of measuring the bug ;-).
msg360675 - (view)	Author: Terry J. Reedy (terry.reedy) *	Date: 2020-01-25 09:01
New changeset d0d9fa8c5e30aff71b6d5e8b2673396622f33270 by Terry Jan Reedy (Cheryl Sabella) in branch 'master': bpo-39388: IDLE: Fix bug when cancelling out of configdialog (GH-18068) https://github.com/python/cpython/commit/d0d9fa8c5e30aff71b6d5e8b2673396622f33270
msg360676 - (view)	Author: miss-islington (miss-islington)	Date: 2020-01-25 09:17
New changeset a23449285430081ea317cc1f203c80c410bbd8b9 by Miss Islington (bot) in branch '3.8': bpo-39388: IDLE: Fix bug when cancelling out of configdialog (GH-18068) https://github.com/python/cpython/commit/a23449285430081ea317cc1f203c80c410bbd8b9
msg360677 - (view)	Author: miss-islington (miss-islington)	Date: 2020-01-25 09:18
New changeset fd9ce2b924263c1f5c5a2f3f3095fe6ae97c1432 by Miss Islington (bot) in branch '3.7': bpo-39388: IDLE: Fix bug when cancelling out of configdialog (GH-18068) https://github.com/python/cpython/commit/fd9ce2b924263c1f5c5a2f3f3095fe6ae97c1432

History
Date	User	Action	Args
2020-01-25 11:37:53	terry.reedy	set	status: open -> closed resolution: fixed stage: patch review -> resolved
2020-01-25 09:18:32	miss-islington	set	messages: + msg360677
2020-01-25 09:17:58	miss-islington	set	nosy: + miss-islington messages: + msg360676
2020-01-25 09:01:22	miss-islington	set	pull_requests: + pull_request17563
2020-01-25 09:01:21	terry.reedy	set	messages: + msg360675
2020-01-25 09:01:19	miss-islington	set	pull_requests: + pull_request17562
2020-01-25 02:19:23	terry.reedy	set	messages: + msg360667
2020-01-19 17:29:34	cheryl.sabella	set	keywords: + patch stage: patch review pull_requests: + pull_request17460
2020-01-19 17:26:54	cheryl.sabella	create