Issue 40459: [easy] undefined names in platform.py [proxy]

The Wayback Machine - https://web.archive.org/web/20210119110724/https://bugs.python.org/issue40459

Issue40459

classification

Title:	[easy] undefined names in platform.py
Type:		Stage:	resolved
Components:	Library (Lib), Windows	Versions:	Python 3.9, Python 3.8, Python 3.7

process

Status:	closed	Resolution:	fixed
Dependencies:		Superseder:
Assigned To:		Nosy List:	Dennis Sweeney, corona10, miss-islington, paul.moore, steve.dower, tim.golden, vstinner, zach.ware
Priority:	normal	Keywords:	newcomer friendly, patch

Created on 2020-04-30 23:45 by vstinner, last changed 2020-05-05 02:57 by vstinner. This issue is now closed.

Messages (4)
msg367808 - (view)	Author: STINNER Victor (vstinner) *	Date: 2020-04-30 23:45
pyflakes found the two following issues in platform.py: Lib/platform.py:401:35 undefined name 'HKEY_LOCAL_MACHINE' Lib/platform.py:402:25 undefined name 'QueryValueEx' Line 353: with winreg.OpenKeyEx(winreg.HKEY_LOCAL_MACHINE, cvkey) as key: return winreg.QueryValueEx(key, 'EditionId')[0] vs Line 401: with winreg.OpenKeyEx(HKEY_LOCAL_MACHINE, cvkey) as key: ptype = QueryValueEx(key, 'CurrentType')[0] This issue seems easy to fix ;-)
msg368099 - (view)	Author: Dong-hee Na (corona10) *	Date: 2020-05-05 02:33
New changeset 1e7e4519a8ddc2239101a0146d788c9161143a77 by Dennis Sweeney in branch 'master': bpo-40459: Fix NameError in platform.py (GH-19855) https://github.com/python/cpython/commit/1e7e4519a8ddc2239101a0146d788c9161143a77
msg368100 - (view)	Author: miss-islington (miss-islington)	Date: 2020-05-05 02:51
New changeset 8ddf91543890e38c76aa0029482c6f5f5c444837 by Miss Islington (bot) in branch '3.7': bpo-40459: Fix NameError in platform.py (GH-19855) https://github.com/python/cpython/commit/8ddf91543890e38c76aa0029482c6f5f5c444837
msg368101 - (view)	Author: miss-islington (miss-islington)	Date: 2020-05-05 02:51
New changeset efc782d29e229924076ffb6645a72f26242fb3ef by Miss Islington (bot) in branch '3.8': bpo-40459: Fix NameError in platform.py (GH-19855) https://github.com/python/cpython/commit/efc782d29e229924076ffb6645a72f26242fb3ef

History
Date	User	Action	Args
2020-05-05 02:57:49	vstinner	set	status: open -> closed stage: patch review -> resolved resolution: fixed versions: + Python 3.7, Python 3.8
2020-05-05 02:51:52	miss-islington	set	messages: + msg368101
2020-05-05 02:51:40	miss-islington	set	messages: + msg368100
2020-05-05 02:33:47	miss-islington	set	pull_requests: + pull_request19228
2020-05-05 02:33:37	miss-islington	set	nosy: + miss-islington pull_requests: + pull_request19227
2020-05-05 02:33:23	corona10	set	nosy: + corona10 messages: + msg368099
2020-05-02 04:32:09	xtreak	set	nosy: + paul.moore, tim.golden, zach.ware, steve.dower components: + Windows
2020-05-02 04:27:22	Dennis Sweeney	set	keywords: + patch nosy: + Dennis Sweeney pull_requests: + pull_request19171 stage: patch review
2020-04-30 23:45:08	vstinner	create