[2.7] bpo-31478: Prevent unwanted behavior in _random.Random.seed() in case the arg has a bad abs() method (GH-3596) #3845

orenmn · 2017-10-01T13:51:05Z

In case the argument of _random.Random.seed() is a long/int subclass, ignore its __abs__() method.
Add a test to test_random to verify that such __abs__() methods are indeed ignored.

https://bugs.python.org/issue31478

serhiy-storchaka

Add a NEWS entry.

serhiy-storchaka · 2017-10-01T14:15:03Z

Lib/test/test_random.py

+        expected_value = self.gen.random()
+        for seed_arg in [42L, BadInt(42), BadLong(42)]:
+            self.gen.seed(seed_arg)
+            self.assertEqual(expected_value, self.gen.random())


Use the actual value at left and the expected value at right.

orenmn added 4 commits Oct 1, 2017

init commit

e15c28c

move the comment

f5300db

simplify the test

eb8ea90

remove blank line

e9d75c6

the-knights-who-say-ni added the CLA signed label Oct 1, 2017

bedevere-bot mentioned this pull request Oct 1, 2017

bpo-31478: Fix an assertion failure in random.seed() in case the 'a' arg has a bad __abs__() method #3596

Merged

bedevere-bot added the awaiting review label Oct 1, 2017

serhiy-storchaka reviewed Oct 1, 2017

View changes

add a NEWS.d item, and make a little fix to the test

27f9260

serhiy-storchaka approved these changes Oct 1, 2017

View changes

bedevere-bot added awaiting merge and removed awaiting review labels Oct 1, 2017

serhiy-storchaka merged commit 13da1a6 into python:2.7 Oct 2, 2017
4 checks passed

Mariatta removed the awaiting merge label Oct 8, 2017

python / cpython Public

[2.7] bpo-31478: Prevent unwanted behavior in _random.Random.seed() in case the arg has a bad abs() method (GH-3596) #3845

[2.7] bpo-31478: Prevent unwanted behavior in _random.Random.seed() in case the arg has a bad abs() method (GH-3596) #3845

orenmn commented Oct 1, 2017 •

edited by bedevere-bot

serhiy-storchaka left a comment

serhiy-storchaka Oct 1, 2017

python / cpython Public

[2.7] bpo-31478: Prevent unwanted behavior in _random.Random.seed() in case the arg has a bad __abs__() method (GH-3596) #3845

[2.7] bpo-31478: Prevent unwanted behavior in _random.Random.seed() in case the arg has a bad __abs__() method (GH-3596) #3845

Conversation

orenmn commented Oct 1, 2017 • edited by bedevere-bot

serhiy-storchaka left a comment

serhiy-storchaka Oct 1, 2017

Choose a reason for hiding this comment

[2.7] bpo-31478: Prevent unwanted behavior in _random.Random.seed() in case the arg has a bad abs() method (GH-3596) #3845

[2.7] bpo-31478: Prevent unwanted behavior in _random.Random.seed() in case the arg has a bad abs() method (GH-3596) #3845

orenmn commented Oct 1, 2017 •

edited by bedevere-bot