bpo-32849: Always use fstat() to validate fds on POSIX #5773

izbyshev · 2018-02-20T14:32:14Z

A previous approach was to usually prefer dup() for that, but
there are various circumstances under which dup() succeeds
for a descriptor unusable for I/O but fstat() fails with EBADF
causing a fatal failure in standard streams initialization.

https://bugs.python.org/issue32849

A previous approach was to usually prefer dup() for that, but there are various circumstances under which dup() succeeds for a descriptor unusable for I/O but fstat() fails with EBADF causing a fatal failure in standard streams initialization.

vstinner · 2019-04-16T09:58:06Z

See also PR #12852.

vstinner · 2019-04-17T16:09:19Z

My PR #12852 is more conservative: it keeps dup() on Linux. I'm not sure why exactly, but I recall that the author of the function, @pitrou, wanted to use dup() on Linux. I'm not convinced by the O_PATH case on Linux, so I merged my conservative change instead. We can move to fstat() on Linux as well if someone comes with a more concrete example against dup().

the-knights-who-say-ni added the CLA signed label Feb 20, 2018

bedevere-bot added the awaiting review label Feb 20, 2018

Add NEWS entry

65f0d57

vstinner mentioned this pull request Apr 16, 2019

bpo-32849: Fix is_valid_fd() on FreeBSD #12852

Merged

vstinner closed this Apr 17, 2019

bpo-32849: Always use fstat() to validate fds on POSIX #5773

bpo-32849: Always use fstat() to validate fds on POSIX #5773

izbyshev commented Feb 20, 2018 •

edited by bedevere-bot

Loading

vstinner commented Apr 16, 2019

vstinner commented Apr 17, 2019

bpo-32849: Always use fstat() to validate fds on POSIX #5773

bpo-32849: Always use fstat() to validate fds on POSIX #5773

Conversation

izbyshev commented Feb 20, 2018 • edited by bedevere-bot Loading

vstinner commented Apr 16, 2019

vstinner commented Apr 17, 2019

izbyshev commented Feb 20, 2018 •

edited by bedevere-bot

Loading