[proxy] web.archive.org — ← back | site home | direct (HTTPS) ↗ | proxy home | ◑ dark◐ light
/ cpython Public
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-29235: Update document for Profiler's context manager #7331

Merged
merged 6 commits into from Jun 7, 2018
Merged

bpo-29235: Update document for Profiler's context manager #7331

merged 6 commits into from Jun 7, 2018

Conversation

Copy link

ssanderson commented Jun 1, 2018 •
edited by bedevere-bot

  • Add a versionadded directive to the note about Profile being a context manager.
  • Remove extra paragraph from NEWS entry.
  • Add an entry to whatsnew for 3.8.

cc @serhiy-storchaka, xref: https://bugs.python.org/issue29235#msg318460

https://bugs.python.org/issue29235

brettcannon requested changes Jun 2, 2018
View changes
Doc/library/profile.rst Outdated
@@ -272,6 +272,8 @@ functions:

pr.print_stats()

.. versionadded:: 3.8
Copy link
Member

brettcannon Jun 2, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this applies to the class definition this isn't accurate since the class isn't new 😉 . I would change this to:

.. versionchanged:: 3.8
   Added context manager support.

Copy link

bedevere-bot commented Jun 2, 2018

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

methane changed the title bpo-29235: Update docs added in GH-6808. bpo-29235: profile: Update document about contextmanager support Jun 7, 2018
methane changed the title bpo-29235: profile: Update document about contextmanager support bpo-29235: Update document for Profiler's context manager Jun 7, 2018
methane merged commit cebe80b into python:master Jun 7, 2018
6 of 9 checks passed
yahya-abou-imran pushed a commit to yahya-abou-imran/cpython that referenced this pull request Nov 2, 2018
bpo-29235: Update document for Profiler's context manager (pythonGH-7331
d80ee1f 
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

brettcannon

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants