[proxy] web.archive.org← back | site home | direct (HTTPS) ↗ | proxy home | ◑ dark◐ light
/ cpython Public
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-25008: Deprecate smtpd and point to aiosmtpd #274

Merged
merged 2 commits into from Feb 24, 2017

Conversation

Copy link
Member

warsaw commented Feb 24, 2017

We should probably also cherry pick this change into 3.4, 3.5, and 3.6 since those are the versions aiosmtpd are compatible with.

@@ -13,6 +13,13 @@

This module offers several classes to implement SMTP (email) servers.

.. seealso::

The `aiosmtpd <http://aiosmtpd.readthedocs.io/en/latest/>`_ package is a
Copy link
Member

vstinner Feb 24, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest to drop the /en/latest/ part of the URL.

Copy link
Member Author

warsaw Feb 24, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WFM, thanks.

vstinner merged commit fba79dc into python:master Feb 24, 2017
Copy link
Member

vstinner commented Feb 24, 2017

Yeah, it's time to say goodbye to asyncore :-(

Copy link
Sponsor Member

Mariatta commented Feb 24, 2017

Hm... we don't have needs backport to 3.4 label..

@Haypo I created an issue about replacing asyncore a while back: http://bugs.python.org/issue28533

warsaw deleted the bpo-25008 branch Feb 24, 2017
Copy link
Member Author

warsaw commented Feb 24, 2017

I guess I'll do the cherry picks. I think they all need merge requests right?

Copy link
Sponsor Member

Mariatta commented Feb 24, 2017

I think they all need merge requests right?
Yes :)

warsaw added a commit to warsaw/cpython that referenced this pull request Feb 24, 2017
warsaw added a commit to warsaw/cpython that referenced this pull request Feb 24, 2017
warsaw added a commit to warsaw/cpython that referenced this pull request Feb 24, 2017
Copy link
Member Author

warsaw commented Feb 24, 2017

@Mariatta It also looks like 3.4 is not a protected branch. I think I can self-approve merges to that branch.

Copy link
Member Author

warsaw commented Feb 24, 2017

Or maybe @dstufft was quicker than my browser. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants