Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
|
Working on fixing failing tests. |
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
On some platform such as VMware ESXi, DefaultSelector fails to detect selector due to default value. This fix adds a check and uses the correct selector depending upon select implementation and actual call. Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
|
I have made the requested changes; please review again |
|
Thanks for making the requested changes! @aeros: please review the changes made to this pull request. |
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
OK, I am going along with this.
|
PS. A meta-remark: please don’t force-push commits in response to code review. This makes changes harder to see for reviewers. We always squash commits when merging. |
I will take a note for the future, Thank you. |
|
You're welcome. Do you need this backported to 3.9? (We'd need to petition the release manager given the next release is rc1.) |
|
@tiran @aeros @gvanrossum Thanks for the reviews. Yes, I would like to backport this to 3.9. |
|
/cc @ambv |
|
Thanks @Akasurde for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9. |
…thonGH-21257) On some platform such as VMware ESXi, DefaultSelector fails to detect selector due to default value. This fix adds a check and uses the correct selector depending upon select implementation and actual call. Fixes: [bpo-41182]() Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com> (cherry picked from commit bcd4783) Co-authored-by: Abhijeet Kasurde <akasurde@redhat.com>
|
GH-21630 is a backport of this pull request to the 3.9 branch. |
…-21257) On some platform such as VMware ESXi, DefaultSelector fails to detect selector due to default value. This fix adds a check and uses the correct selector depending upon select implementation and actual call. Fixes: [bpo-41182]() Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com> (cherry picked from commit bcd4783) Co-authored-by: Abhijeet Kasurde <akasurde@redhat.com>
…thonGH-21257) On some platform such as VMware ESXi, DefaultSelector fails to detect selector due to default value. This fix adds a check and uses the correct selector depending upon select implementation and actual call. Fixes: [bpo-41182]() Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
…thonGH-21257) On some platform such as VMware ESXi, DefaultSelector fails to detect selector due to default value. This fix adds a check and uses the correct selector depending upon select implementation and actual call. Fixes: [bpo-41182]() Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
…thonGH-21257) On some platform such as VMware ESXi, DefaultSelector fails to detect selector due to default value. This fix adds a check and uses the correct selector depending upon select implementation and actual call. Fixes: [bpo-41182]() Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
On some platform such as VMware ESXi, DefaultSelector fails
to detect selector due to default value.
This fix adds a check and uses the correct selector depending upon
select implementation and actual call.
Fixes: bpo-41182
Signed-off-by: Abhijeet Kasurde akasurde@redhat.com
https://bugs.python.org/issue41182
Automerge-Triggered-By: @gvanrossum