[proxy] web.archive.org — ← back | site home | direct (HTTPS) ↗ | proxy home | ◑ dark◐ light
/ cpython Public
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-20928: support base-URL and recursive includes in etree.ElementInclude #5723

Merged
merged 4 commits into from Nov 25, 2019
Merged

bpo-20928: support base-URL and recursive includes in etree.ElementInclude #5723

merged 4 commits into from Nov 25, 2019

Conversation

Copy link
Contributor

scoder commented Feb 17, 2018 •
edited by bedevere-bot

scoder force-pushed the etree_xinclude branch 3 times, most recently from 534e416 to bc8bfc2 Compare Feb 17, 2018
Copy link

ruffsl commented Feb 19, 2018

I like the new configurable base_url!

As mentioned in this message from the originating issue, would it at all be possible to add the xml:base attribute to elements included from locations with a different base URI, as to comply with the XInclude standard? Just tested bc8bfc2, and this still seems to be missing.

scoder force-pushed the etree_xinclude branch 2 times, most recently from 448d126 to 4d53056 Compare Feb 23, 2018
Copy link
Contributor Author

scoder commented Mar 30, 2018

Added news entry, rebased to latest (3.8) master.

Copy link
Contributor Author

scoder commented Mar 30, 2018

Lacks a documentation update, because there is no documentation for the overall ElementInclude feature in CPython. I created issue 33187 for this. When someone writes documentation, this addition is easy to include there.

Copy link
Contributor Author

scoder commented Apr 14, 2019

One remaining issue: how can users disable recursive include processing if they want to?

scoder closed this Sep 10, 2019
scoder reopened this Sep 10, 2019
scoder merged commit c6a7bdb into python:master Nov 25, 2019
scoder deleted the etree_xinclude branch Nov 25, 2019
Copy link

bedevere-bot commented Nov 25, 2019

@scoder: Please replace # with GH- in the commit message next time. Thanks!

jacobneiltaylor pushed a commit to jacobneiltaylor/cpython that referenced this pull request Dec 5, 2019
bpo-20928: support base-URL and recursive includes in etree.ElementIn…
2adac41 
…clude (python#5723)

* bpo-20928: bring elementtree's XInclude support en-par with the implementation in lxml by adding support for recursive includes and a base-URL.

* bpo-20928: Support xincluding the same file multiple times, just not recursively.

* bpo-20928: Add 'max_depth' parameter to xinclude that limits the maximum recursion depth to 6 by default.

* Add news entry for updated ElementInclude support
shihai1991 pushed a commit to shihai1991/cpython that referenced this pull request Jan 31, 2020
bpo-20928: support base-URL and recursive includes in etree.ElementIn…
67c998c 
…clude (python#5723)

* bpo-20928: bring elementtree's XInclude support en-par with the implementation in lxml by adding support for recursive includes and a base-URL.

* bpo-20928: Support xincluding the same file multiple times, just not recursively.

* bpo-20928: Add 'max_depth' parameter to xinclude that limits the maximum recursion depth to 6 by default.

* Add news entry for updated ElementInclude support
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants