bpo-31178: Mock os.waitpid() in test_subprocess #3896

vstinner · 2017-10-05T13:08:51Z

Fix test_exception_errpipe_bad_data() and
test_exception_errpipe_normal() of test_subprocess: mock os.waitpid()
to avoid calling the real os.waitpid(0, 0) which is an unexpected
side effect of the test.

https://bugs.python.org/issue31178

Fix test_exception_errpipe_bad_data() and test_exception_errpipe_normal() of test_subprocess: mock os.waitpid() to avoid calling the real os.waitpid(0, 0) which is an unexpected side effect of the test.

miss-islington · 2017-10-05T13:33:21Z

Thanks @Haypo for the PR 🌮🎉.. I'm working now to backport this PR to: 3.6.
🐍🍒⛏🤖

Fix test_exception_errpipe_bad_data() and test_exception_errpipe_normal() of test_subprocess: mock os.waitpid() to avoid calling the real os.waitpid(0, 0) which is an unexpected side effect of the test. (cherry picked from commit 11045c9)

bedevere-bot · 2017-10-05T13:34:39Z

GH-3897 is a backport of this pull request to the 3.6 branch.

Fix test_exception_errpipe_bad_data() and test_exception_errpipe_normal() of test_subprocess: mock os.waitpid() to avoid calling the real os.waitpid(0, 0) which is an unexpected side effect of the test. (cherry picked from commit 11045c9)

bpo-31178: Mock os.waitpid() in test_subprocess

5484996

Fix test_exception_errpipe_bad_data() and test_exception_errpipe_normal() of test_subprocess: mock os.waitpid() to avoid calling the real os.waitpid(0, 0) which is an unexpected side effect of the test.

vstinner requested a review from gpshead as a code owner October 5, 2017 13:08

the-knights-who-say-ni added the CLA signed label Oct 5, 2017

bedevere-bot added the awaiting merge label Oct 5, 2017

vstinner added the skip news label Oct 5, 2017

vstinner merged commit 11045c9 into python:master Oct 5, 2017

bedevere-bot removed the awaiting merge label Oct 5, 2017

vstinner deleted the subprocess_errpipe branch October 5, 2017 13:32

vstinner added the needs backport to 3.6 label Oct 5, 2017

bedevere-bot removed the needs backport to 3.6 label Oct 5, 2017

bpo-31178: Mock os.waitpid() in test_subprocess #3896

bpo-31178: Mock os.waitpid() in test_subprocess #3896

vstinner commented Oct 5, 2017 •

edited by bedevere-bot

Loading

miss-islington commented Oct 5, 2017

bedevere-bot commented Oct 5, 2017

bpo-31178: Mock os.waitpid() in test_subprocess #3896

bpo-31178: Mock os.waitpid() in test_subprocess #3896

Conversation

vstinner commented Oct 5, 2017 • edited by bedevere-bot Loading

miss-islington commented Oct 5, 2017

bedevere-bot commented Oct 5, 2017

vstinner commented Oct 5, 2017 •

edited by bedevere-bot

Loading