[proxy] web.archive.org — ← back | site home | direct (HTTPS) ↗ | proxy home | ◑ dark◐ light
/ cpython Public
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-35499: make profile-opt don't override CFLAGS_NODIST #11164

Merged
merged 1 commit into from Dec 16, 2018
Merged

bpo-35499: make profile-opt don't override CFLAGS_NODIST #11164

merged 1 commit into from Dec 16, 2018

Conversation

Copy link
Member

vstinner commented Dec 14, 2018 •
edited by bedevere-bot

"make profile-opt" no longer replaces CFLAGS_NODIST with CFLAGS. It
now adds profile-guided optimization (PGO) flags to CFLAGS_NODIST,
existing CFLAGS_NODIST flags are kept.

https://bugs.python.org/issue35499

Copy link
Member Author

vstinner commented Dec 14, 2018

cc @stratakis

bpo-35499: make profile-opt don't override CFLAGS_NODIST
123f165 
"make profile-opt" no longer replaces CFLAGS_NODIST with CFLAGS. It
now adds profile-guided optimization (PGO) flags to CFLAGS_NODIST,
existing CFLAGS_NODIST flags are kept.
Copy link
Member

ned-deily commented Dec 14, 2018

It looks good in principle but I won't be able to test until next week.

Copy link
Member Author

vstinner commented Dec 14, 2018

It looks good in principle but I won't be able to test until next week.

I made some tests to ensure that CFLAGS_NODIST flags are kept: https://bugs.python.org/issue35499#msg331851 Does it look good to you?

gpshead approved these changes Dec 14, 2018
View changes
Copy link
Member

gpshead left a comment

This makes sense.

Copy link
Member Author

vstinner commented Dec 16, 2018

Thanks for the review! I wasn't confident with this change.

vstinner merged commit 640ed52 into python:master Dec 16, 2018
Copy link
Contributor

miss-islington commented Dec 16, 2018

Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

vstinner deleted the cflags_nodist branch Dec 16, 2018
Copy link

bedevere-bot commented Dec 16, 2018

GH-11179 is a backport of this pull request to the 3.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 16, 2018
bpo-35499: make profile-opt don't override CFLAGS_NODIST (pythonGH-11164
69adf6b 
)

"make profile-opt" no longer replaces CFLAGS_NODIST with CFLAGS. It
now adds profile-guided optimization (PGO) flags to CFLAGS_NODIST,
existing CFLAGS_NODIST flags are kept.
(cherry picked from commit 640ed52)

Co-authored-by: Victor Stinner <vstinner@redhat.com>
miss-islington mentioned this pull request Dec 16, 2018
Merged
vstinner added a commit that referenced this pull request Dec 16, 2018
bpo-35499: make profile-opt don't override CFLAGS_NODIST (GH-11164) (G…
9a47585 
…H-11179)

"make profile-opt" no longer replaces CFLAGS_NODIST with CFLAGS. It
now adds profile-guided optimization (PGO) flags to CFLAGS_NODIST,
existing CFLAGS_NODIST flags are kept.
(cherry picked from commit 640ed52)

Co-authored-by: Victor Stinner <vstinner@redhat.com>
Copy link
Contributor

stratakis commented Dec 17, 2018

Any chance for a 3.6 backport?

This was referenced Dec 17, 2018
Merged
Closed
Merged
ned-deily pushed a commit that referenced this pull request Dec 20, 2018
bpo-35499: make profile-opt don't override CFLAGS_NODIST (GH-11164) (G…
782e1d5 
…H-11267)

"make profile-opt" no longer replaces CFLAGS_NODIST with CFLAGS. It
now adds profile-guided optimization (PGO) flags to CFLAGS_NODIST,
existing CFLAGS_NODIST flags are kept.

(cherry picked from commit 640ed52)
ned-deily pushed a commit to ned-deily/cpython that referenced this pull request Dec 23, 2018
bpo-35499: make profile-opt don't override CFLAGS_NODIST (pythonGH-11164
7e4e4bd 
) (pythonGH-11179)

"make profile-opt" no longer replaces CFLAGS_NODIST with CFLAGS. It
now adds profile-guided optimization (PGO) flags to CFLAGS_NODIST,
existing CFLAGS_NODIST flags are kept.
(cherry picked from commit 640ed52)

Co-authored-by: Victor Stinner <vstinner@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

gpshead

benjaminp

ned-deily

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants