[proxy] web.archive.org — ← back | site home | direct (HTTPS) ↗ | proxy home | ◑ dark◐ light
/ cpython Public
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[3.7] bpo-33618: Enable TLS 1.3 in tests (GH-7079) #7082

Merged
merged 1 commit into from
May 23, 2018
Merged

[3.7] bpo-33618: Enable TLS 1.3 in tests (GH-7079) #7082

merged 1 commit into from
May 23, 2018

Conversation

Copy link
Contributor

miss-islington commented May 23, 2018 •
edited by bedevere-bot
Loading

TLS 1.3 behaves slightly different than TLS 1.2. Session tickets and TLS
client cert auth are now handled after the initialy handshake. Tests now
either send/recv data to trigger session and client certs. Or tests
ignore ConnectionResetError / BrokenPipeError on the server side to
handle clients that force-close the socket fd.

To test TLS 1.3, OpenSSL 1.1.1-pre7-dev (git master + OpenSSL PR
openssl/openssl#6340) is required.

Signed-off-by: Christian Heimes christian@python.org
(cherry picked from commit 529525f)

Co-authored-by: Christian Heimes christian@python.org

https://bugs.python.org/issue33618

bpo-33618: Enable TLS 1.3 in tests (pythonGH-7079)
8e35291 
TLS 1.3 behaves slightly different than TLS 1.2. Session tickets and TLS
client cert auth are now handled after the initialy handshake. Tests now
either send/recv data to trigger session and client certs. Or tests
ignore ConnectionResetError / BrokenPipeError on the server side to
handle clients that force-close the socket fd.

To test TLS 1.3, OpenSSL 1.1.1-pre7-dev (git master + OpenSSL PR
openssl/openssl#6340) is required.

Signed-off-by: Christian Heimes <christian@python.org>
(cherry picked from commit 529525f)

Co-authored-by: Christian Heimes <christian@python.org>
miss-islington requested review from 1st1, asvetlov and a team as code owners May 23, 2018 20:24
bedevere-bot mentioned this pull request May 23, 2018
Merged
Copy link
Contributor Author

@tiran: Backport status check is done, and it's a success ✅ .

tiran merged commit 72ef4fc into python:3.7 May 23, 2018
Copy link
Contributor Author

Thanks, @tiran!

miss-islington deleted the backport-529525f-3.7 branch May 23, 2018 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

1st1 Awaiting requested review from 1st1 1st1 is a code owner

asvetlov Awaiting requested review from asvetlov asvetlov is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants