[proxy] web.archive.org — ← back | site home | direct (HTTPS) ↗ | proxy home | ◑ dark◐ light
/ cpython Public
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-35682: Fix _ProactorBasePipeTransport._force_close() #11462

Merged
merged 1 commit into from Jan 8, 2019
Merged

bpo-35682: Fix _ProactorBasePipeTransport._force_close() #11462

merged 1 commit into from Jan 8, 2019

Conversation

Copy link
Member

vstinner commented Jan 8, 2019 •
edited by bedevere-bot

bpo-32622, bpo-35682: Fix a bug in the sendfile() implementation of
asyncio.ProactorEventLoop: don't attempt to the result of an internal
future if it's already done.

Fix asyncio _ProactorBasePipeTransport._force_close(): don't set the
result of _empty_waiter if it's already done.

https://bugs.python.org/issue35682

vstinner requested review from 1st1 and asvetlov as code owners Jan 8, 2019
bpo-35682: Fix _ProactorBasePipeTransport._force_close()
4565e01 
bpo-32622, bpo-35682: Fix asyncio.ProactorEventLoop.sendfile(): don't
attempt to set the result of an internal future if it's already done.

Fix asyncio _ProactorBasePipeTransport._force_close(): don't set the
result of _empty_waiter if it's already done.
vstinner merged commit 80fda71 into python:master Jan 8, 2019
vstinner deleted the proactor_sendfile branch Jan 8, 2019
Copy link
Contributor

miss-islington commented Jan 8, 2019

Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

Copy link

bedevere-bot commented Jan 8, 2019

GH-11463 is a backport of this pull request to the 3.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 8, 2019
bpo-35682: Fix _ProactorBasePipeTransport._force_close() (pythonGH-11462
51ba520 
)

bpo-32622, bpo-35682: Fix asyncio.ProactorEventLoop.sendfile(): don't
attempt to set the result of an internal future if it's already done.

Fix asyncio _ProactorBasePipeTransport._force_close(): don't set the
result of _empty_waiter if it's already done.
(cherry picked from commit 80fda71)

Co-authored-by: Victor Stinner <vstinner@redhat.com>
miss-islington added a commit that referenced this pull request Jan 8, 2019
bpo-35682: Fix _ProactorBasePipeTransport._force_close() (GH-11462)
88bd26a 
bpo-32622, bpo-35682: Fix asyncio.ProactorEventLoop.sendfile(): don't
attempt to set the result of an internal future if it's already done.

Fix asyncio _ProactorBasePipeTransport._force_close(): don't set the
result of _empty_waiter if it's already done.
(cherry picked from commit 80fda71)

Co-authored-by: Victor Stinner <vstinner@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

1st1

asvetlov

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants