[proxy] web.archive.org← back | site home | direct (HTTPS) ↗ | proxy home | ◑ dark◐ light

[3.6] bpo-35257: fix broken BLDSHARED - needs LDFLAGS too (GH-11297) by miss-islington · Pull Request #11299 · python/cpython

the-knights-who-say-ni

Conversation

`BLDSHARED` needs to have both `LDFLAGS` and `LDFLAGS_NODIST`, not just `LDFLAGS_NODIST`; `PY_CORE_LDFLAGS` provides both.  For example, as it stands now with just `LDFLAGS_NODIST`, macOS universal builds are broken as the necessary `-arch` flags are no longer passed to the standard library extension module link step from `setup.py` resulting in extension modules being single architecture only.

https://bugs.python.org/issue35257
(cherry picked from commit 44a3ee0)

Co-authored-by: Ned Deily <nad@python.org>

Merged

ned-deily merged commit 68f5dfd into python:3.6

Dec 23, 2018

5 checks passed

bedevere/issue-number Issue number 35257 found

Details

bedevere/maintenance-branch-pr Valid maintenance branch PR title.

bedevere/news "skip news" label found

continuous-integration/appveyor/pr AppVeyor build succeeded

Details

continuous-integration/travis-ci/pr The Travis CI build passed

Details