[proxy] web.archive.org — ← back | site home | direct (HTTPS) ↗ | proxy home | ◑ dark◐ light
/ cpython Public

bpo-36922: use Py_TPFLAGS_METHOD_DESCRIPTOR in lookup_maybe_method() #13865

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 17, 2019
Merged

bpo-36922: use Py_TPFLAGS_METHOD_DESCRIPTOR in lookup_maybe_method() #13865

merged 2 commits into from
Jun 17, 2019

Conversation

Copy link
Contributor

jdemeyer commented Jun 6, 2019 •
edited by bedevere-bot
Loading

lookup_maybe_method is an obvious place where the use case of Py_TPFLAGS_METHOD_DESCRIPTOR applies.

IMHO, this is safe enough for 3.8 but the reviewer should judge that.

CC @encukou @vstinner

https://bugs.python.org/issue36922

Copy link
Contributor Author

CC @methane

methane merged commit 2e9954d into python:master Jun 17, 2019
Copy link
Contributor

Thanks @jdemeyer for the PR, and @methane for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

Copy link

GH-14155 is a backport of this pull request to the 3.8 branch.

Copy link
Member

methane commented Jun 17, 2019

OK, I think this is safe enough, and this is part of PEP 590 implementation.
Polishing a new feature in beta period is allowed when it is safe enough.

Copy link
Contributor Author

Thanks!

jdemeyer deleted the pep590_lookup_maybe_method branch June 17, 2019 11:55
miss-islington added a commit that referenced this pull request Jun 17, 2019
bpo-36922: use Py_TPFLAGS_METHOD_DESCRIPTOR in lookup_maybe_method() (G…
988fff5 
…H-13865)

(cherry picked from commit 2e9954d)

Co-authored-by: Jeroen Demeyer <J.Demeyer@UGent.be>
lisroach pushed a commit to lisroach/cpython that referenced this pull request Sep 10, 2019
bpo-36922: use Py_TPFLAGS_METHOD_DESCRIPTOR in lookup_maybe_method() (p…
ebda540 
…ythonGH-13865)
DinoV pushed a commit to DinoV/cpython that referenced this pull request Jan 14, 2020
bpo-36922: use Py_TPFLAGS_METHOD_DESCRIPTOR in lookup_maybe_method() (p…
2386b28 
…ythonGH-13865)
mmcqd mentioned this pull request Jan 30, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

mangrisano mangrisano approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants