[proxy] web.archive.org — ← back | site home | direct (HTTPS) ↗ | proxy home | ◑ dark◐ light
/ cpython Public
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[3.7] bpo-35308: Fix regression where BROWSER env var is not respected. (GH-10693) #10729

Merged
merged 1 commit into from
Nov 26, 2018
Merged

[3.7] bpo-35308: Fix regression where BROWSER env var is not respected. (GH-10693) #10729

merged 1 commit into from
Nov 26, 2018

Conversation

Copy link
Contributor

miss-islington commented Nov 26, 2018 •
edited by bedevere-bot
Loading

Regression introduced in e3ce695 and 25b804a, where the old parameter
update_tryorder to _synthesize was first ignored, then given the opposite
value in the attempt to fix bpo-31014.
(cherry picked from commit 8c281ed)

Co-authored-by: Zhiming Wang i@zhimingwang.org

https://bugs.python.org/issue35308

bpo-35308: Fix regression where BROWSER env var is not respected. (py…
4d09d06 
…thonGH-10693)

Regression introduced in e3ce695 and 25b804a, where the old parameter
update_tryorder to _synthesize was first ignored, then given the opposite
value in the attempt to fix bpo-31014.
(cherry picked from commit 8c281ed)

Co-authored-by: Zhiming Wang <i@zhimingwang.org>
bedevere-bot mentioned this pull request Nov 26, 2018
Merged
bedevere-bot added type-bug An unexpected behavior, bug, or error awaiting review labels Nov 26, 2018
Copy link
Contributor Author

@zmwangx and @serhiy-storchaka: Status check is done, and it's a success ✅ .

miss-islington merged commit 2a37f01 into python:3.7 Nov 26, 2018
miss-islington deleted the backport-8c281ed-3.7 branch November 26, 2018 21:49
Copy link
Contributor Author

@zmwangx and @serhiy-storchaka: Status check is done, and it's a success ✅ .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

serhiy-storchaka serhiy-storchaka approved these changes

Assignees
No one assigned
Labels
type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants