[proxy] web.archive.org — ← back | site home | direct (HTTPS) ↗ | proxy home | ◑ dark◐ light

/ cpython Public

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-31284: IDLE: Fix WindowList warning message when running tests #3212

Closed
wants to merge 1 commit into from
Closed

bpo-31284: IDLE: Fix WindowList warning message when running tests #3212

wants to merge 1 commit into from

Conversation

Copy link
Contributor

csabella commented Aug 26, 2017 •
edited by bedevere-bot

terryjreedy requested changes Aug 26, 2017
View changes
Copy link
Member

terryjreedy left a comment •
edited

I think this is more likely a cover-up than a real fix.

The subsequent experiments discussed on the tracker convince me more of this. Masking the warning would be a last resort for getting a test to close cleanly.

Copy link

bedevere-bot commented Aug 26, 2017

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I didn't expect the Spanish Inquisition!. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

Copy link

terryjreedy commented Aug 27, 2017

The problem in bpo-30617 is fixed by calling close.

csabella deleted the bpo31284 branch Aug 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

terryjreedy

Assignees
No one assigned
Labels
CLA signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants