[proxy] web.archive.org — ← back | site home | direct (HTTPS) ↗ | proxy home | ◑ dark◐ light
/ cpython Public

[3.7] bpo-27639: Correct return type for UserList slicing operation (GH-13169) #13181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[3.7] bpo-27639: Correct return type for UserList slicing operation (GH-13169) #13181

wants to merge 1 commit into from

Conversation

Copy link
Contributor

miss-islington commented May 7, 2019 •
edited by bedevere-bot
Loading

  • BPO-27639: Correct return type for UserList slicing operation

Added logic to getitem magic method for UserList to ensure that the return
type matches that of self.
(cherry picked from commit b1c3167)

Co-authored-by: Michael Blahay mblahay@users.noreply.github.com

https://bugs.python.org/issue27639

bpo-27639: Correct return type for UserList slicing operation (python…
7a7bb20 
…GH-13169)

* BPO-27639: Correct return type for UserList slicing operation

Added logic to __getitem__ magic method for UserList to ensure that the return
type matches that of self.
(cherry picked from commit b1c3167)

Co-authored-by: Michael Blahay <mblahay@users.noreply.github.com>
miss-islington requested a review from rhettinger as a code owner May 7, 2019 21:41
bedevere-bot mentioned this pull request May 7, 2019
Merged
bedevere-bot added type-bug An unexpected behavior, bug, or error awaiting review labels May 7, 2019
Copy link
Contributor Author

@mblahay and @markshannon: Status check is done, and it's a failure ❌ .

Copy link
Contributor

mblahay commented May 8, 2019

The error during AppVeyor build does not seem to have anything to do with the change. Can the test be rerun.

markshannon closed this May 8, 2019
miss-islington deleted the backport-b1c3167-3.7 branch May 8, 2019 15:02
Copy link
Contributor

mblahay commented May 8, 2019

My local test execution on a version prior to this change is still showing the error, this time in Linux

0:01:38 load avg: 1.79 [ 25/416] test_asyncio passed (58 sec 429 ms)
Future exception was never retrieved
future:
Traceback (most recent call last):
File "/home/mb18433/Projects/cpython/cpython/Lib/asyncio/subprocess.py", line 152, in _feed_stdin
await self.stdin.drain()
File "/home/mb18433/Projects/cpython/cpython/Lib/asyncio/streams.py", line 353, in drain
await self._protocol._drain_helper()
File "/home/mb18433/Projects/cpython/cpython/Lib/asyncio/streams.py", line 209, in _drain_helper
await waiter
BrokenPipeError
Future exception was never retrieved
future:
Traceback (most recent call last):
File "/home/mb18433/Projects/cpython/cpython/Lib/asyncio/subprocess.py", line 152, in _feed_stdin
await self.stdin.drain()
File "/home/mb18433/Projects/cpython/cpython/Lib/asyncio/streams.py", line 353, in drain
await self._protocol._drain_helper()
File "/home/mb18433/Projects/cpython/cpython/Lib/asyncio/streams.py", line 209, in _drain_helper
await waiter
BrokenPipeError

Copy link
Member

My local test execution on a version prior to this change is still showing the error, this time in Linux

There are warnings, but errors: test_asyncio passed (success). You may open an issue at https://bugs.python.org/ about these warnings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

rhettinger Awaiting requested review from rhettinger rhettinger is a code owner

Assignees
No one assigned
Labels
awaiting review type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants