Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
6ebeb17
to
359d355
Compare
AH, yes, thank you, much better.
Yes that was the plan. |
|
Thanks for making the requested changes! @gpshead: please review the changes made to this pull request. |
… 3.8 HMAC's digestmod was deprecated marked for removal in 3.6, then bumped to 3.8
lets not mention the old behavior in the docstring and explicitly document that the `digestmod` parameter is required.
359d355
to
d74f873
Compare
|
Thanks, Much appreciated. I'm guessing you'll be at the core-dev sprint, and wish you all to enjoy it (but still take some time off). |
… 3.8 (pythonGH-7063) HMAC's digestmod was deprecated marked for removal, this removes it as planned.
Code change was made in python#7063, for https://bugs.python.org/issue33604.
HMAC's digestmod was deprecated marked for removal in 3.6, then to 3.8 (in #7062).
This is on top of #7062, which fix the deprecation notice to use the correct Python version.
https://bugs.python.org/issue33604