[proxy] web.archive.org — ← back | site home | direct (HTTPS) ↗ | proxy home | ◑ dark◐ light
/ cpython Public
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-32221: makeipaddr(): remove interface part + speedup (GH-5449) #5449

Merged
merged 1 commit into from
Feb 12, 2018
Merged

bpo-32221: makeipaddr(): remove interface part + speedup (GH-5449) #5449

merged 1 commit into from
Feb 12, 2018

Conversation

Copy link
Contributor

socketpair commented Jan 30, 2018 •
edited by bedevere-bot
Loading

Copy link
Contributor Author

@1st1 I fixed only tests comparing to previous try. Please review, but don't merge. I will double-check Linux, Windows and Mac OS X builds by hand. I will notify you when my manual checks will be done.

socketpair changed the title bpo-32221: makeipaddr(): remove interface part + speedup (GH-4724) bpo-32221: makeipaddr(): remove interface part + speedup (GH-5449) Jan 30, 2018
Copy link
Contributor Author

@1st1 everything works as expected. Please review again and merge.

Copy link
Contributor Author

Again: only tests were changed.

Copy link
Contributor Author

@1st1

Copy link
Contributor Author

@1st1 ping

ammaraskar mentioned this pull request Feb 8, 2018
Closed
Copy link
Contributor Author

:(

Copy link
Contributor Author

@1st1 @asvetlov What should I do in order to merge that ?

Copy link
Member

1st1 commented Feb 12, 2018

Please be a bit more patient. I was offline the last 10 days and couldn't take care of this.

1st1 merged commit 7766b96 into python:master Feb 12, 2018
Copy link

@1st1: Please replace # with GH- in the commit message next time. Thanks!

Copy link
Contributor

Thanks @socketpair for the PR, and @1st1 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

Copy link

GH-5641 is a backport of this pull request to the 3.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 12, 2018
bpo-32221: makeipaddr(): remove interface part + speedup (pythonGH-5449…
d53ce78 
…) (pythonGH-5449)

(cherry picked from commit 7766b96)

Co-authored-by: Коренберг Марк <socketpair@gmail.com>
1st1 pushed a commit that referenced this pull request Feb 12, 2018
bpo-32221: makeipaddr(): remove interface part + speedup (GH-5449) (G…
0442599 
…H-5449) (#5641)

(cherry picked from commit 7766b96)

Co-authored-by: Коренберг Марк <socketpair@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants