[proxy] web.archive.org — ← back | site home | direct (HTTPS) ↗ | proxy home | ◑ dark◐ light

/ cpython Public

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-34974: Do not replace unexpected errors in bytes() and bytearray(). #9852

Merged
merged 2 commits into from Oct 14, 2018
Merged

bpo-34974: Do not replace unexpected errors in bytes() and bytearray(). #9852

merged 2 commits into from Oct 14, 2018

Conversation

Copy link
Member

serhiy-storchaka commented Oct 13, 2018 •
edited by bedevere-bot

bytes and bytearray constructors converted unexpected exceptions
(e.g. MemoryError and KeyboardInterrupt) to TypeError.

https://bugs.python.org/issue34974

bpo-34974: Do not replace unexpected errors in bytes() and bytearray().
2dd7c6a 
bytes and bytearray constructors converted unexpected exceptions
(e.g. MemoryError and KeyboardInterrupt) to TypeError.
serhiy-storchaka requested a review from methane Oct 14, 2018
methane approved these changes Oct 14, 2018
View changes
Copy link
Member

methane left a comment

LGTM

serhiy-storchaka merged commit e890421 into python:master Oct 14, 2018
5 checks passed
Copy link

miss-islington commented Oct 14, 2018

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.6, 3.7.
🐍🍒⛏🤖

serhiy-storchaka deleted the bytes-constructor-exceptions branch Oct 14, 2018
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Oct 14, 2018
bpo-34974: Do not replace unexpected errors in bytes() and bytearray(…
33555b5 
…). (pythonGH-9852)

bytes and bytearray constructors converted unexpected exceptions
(e.g. MemoryError and KeyboardInterrupt) to TypeError.
(cherry picked from commit e890421)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
Copy link

bedevere-bot commented Oct 14, 2018

GH-9878 is a backport of this pull request to the 3.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this issue Oct 14, 2018
bpo-34974: Do not replace unexpected errors in bytes() and bytearray(…
018db25 
…). (pythonGH-9852)

bytes and bytearray constructors converted unexpected exceptions
(e.g. MemoryError and KeyboardInterrupt) to TypeError.
(cherry picked from commit e890421)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
Copy link

bedevere-bot commented Oct 14, 2018

GH-9879 is a backport of this pull request to the 3.6 branch.

miss-islington added a commit that referenced this issue Oct 14, 2018
bpo-34974: Do not replace unexpected errors in bytes() and bytearray(…
1370832 
…). (GH-9852)

bytes and bytearray constructors converted unexpected exceptions
(e.g. MemoryError and KeyboardInterrupt) to TypeError.
(cherry picked from commit e890421)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
miss-islington added a commit that referenced this issue Oct 14, 2018
bpo-34974: Do not replace unexpected errors in bytes() and bytearray(…
08ba7eb 
…). (GH-9852)

bytes and bytearray constructors converted unexpected exceptions
(e.g. MemoryError and KeyboardInterrupt) to TypeError.
(cherry picked from commit e890421)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this issue Oct 15, 2018
[2.7] bpo-34974: Do not replace unexpected errors in bytes() and byte…
badbead 
…array(). (pythonGH-9852)

bytes and bytearray constructors converted unexpected exceptions
(e.g. MemoryError and KeyboardInterrupt) to TypeError..
(cherry picked from commit e890421)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this issue Oct 15, 2018
[2.7] bpo-34974: Do not replace unexpected errors in bytearray(). (py…
fdf7582 
…thonGH-9852)

The bytearray constructor converted unexpected exceptions
(e.g. MemoryError and KeyboardInterrupt) to TypeError.
(cherry picked from commit e890421)
serhiy-storchaka added a commit that referenced this issue Oct 15, 2018
[2.7] bpo-34974: Do not replace unexpected errors in bytearray(). (GH…
43308df 
…-9852) (GH-9885)

The bytearray constructor converted unexpected exceptions
(e.g. MemoryError and KeyboardInterrupt) to TypeError.
(cherry picked from commit e890421)
bradengroom pushed a commit to bradengroom/cpython that referenced this issue Oct 25, 2018
[2.7] bpo-34974: Do not replace unexpected errors in bytearray(). (py…
92ac9ca 
…thonGH-9852) (pythonGH-9885)

The bytearray constructor converted unexpected exceptions
(e.g. MemoryError and KeyboardInterrupt) to TypeError.
(cherry picked from commit e890421)
yahya-abou-imran pushed a commit to yahya-abou-imran/cpython that referenced this issue Nov 2, 2018
bpo-34974: Do not replace unexpected errors in bytes() and bytearray(…
e119aea 
…). (pythonGH-9852)

bytes and bytearray constructors converted unexpected exceptions
(e.g. MemoryError and KeyboardInterrupt) to TypeError.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

methane

ZackerySpytz

Assignees
No one assigned
Labels
CLA signed type-bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants