[proxy] web.archive.org← back | site home | direct (HTTPS) ↗ | proxy home | ◑ dark◐ light
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.5] bpo-31095: fix potential crash during GC #3196

Merged
merged 3 commits into from Sep 26, 2017

Conversation

Copy link
Member

methane commented Aug 24, 2017

(cherry picked from commit a6296d3)

https://bugs.python.org/issue31095

(cherry picked from commit a6296d3)
larryhastings requested a review from zooba Sep 25, 2017
Copy link
Contributor

larryhastings commented Sep 25, 2017

Hi, Steve, this is failing on link, can you look in to it?

Copy link
Member Author

methane commented Sep 25, 2017

Link error message in AppVeyor:

[00:03:36]   Finished generating code
[00:03:37]      Creating library C:\projects\cpython\PCBuild\win32\_elementtree.lib and object C:\projects\cpython\PCBuild\win32\_elementtree.exp
[00:03:37] xmlparse.obj : error LNK2001: unresolved external symbol __Expat_LoadLibrary [C:\projects\cpython\PCbuild\_elementtree.vcxproj]
[00:03:37] C:\projects\cpython\PCBuild\win32\_elementtree.pyd : fatal error LNK1120: 1 unresolved externals [C:\projects\cpython\PCbuild\_elementtree.vcxproj]
Copy link
Member

zooba commented Sep 25, 2017

Looks like the pyexpat.vcxproj file was never updated with the last update, and whoever merged that updated didn't run appveyor (or they ignored the failure).

I'll send a PR to update the file. Looks like 3.6 got the change okay, so guessing it's just 3.5.

Copy link
Member

zooba commented Sep 25, 2017

See #3751 for the fix.

methane closed this Sep 25, 2017
methane reopened this Sep 25, 2017
larryhastings merged commit 0fcc033 into python:3.5 Sep 26, 2017
4 checks passed
4 checks passed
bedevere/issue-number Issue number 31095 found
Details
bedevere/news News entry found in Misc/NEWS.d
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Mariatta removed the awaiting merge label Oct 8, 2017
methane deleted the methane:backport-a6296d3-3.5 branch Dec 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants