[proxy] web.archive.org — ← back | site home | direct (HTTPS) ↗ | proxy home | ◑ dark◐ light
/ cpython Public
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-31569: globally fix case for PCbuild where it was PCBuild #3711

Merged
merged 1 commit into from Sep 25, 2017
Merged

bpo-31569: globally fix case for PCbuild where it was PCBuild #3711

merged 1 commit into from Sep 25, 2017

Conversation

Copy link
Contributor

gronke commented Sep 23, 2017 •
edited by bedevere-bot

While setting up the development environment for Windows I've noticed PCbuild/ was sometimes written with a different case. This pull-requests replaces all occasions of PCBuild with PCbuild.

https://bugs.python.org/issue31569

gronke requested a review from a team as a code owner Sep 23, 2017
Copy link
Member

serhiy-storchaka commented Sep 24, 2017

Please open an issue on the bug tracker for discussing your changes.

File systems on Windows are case-insensitive. It is not clear what is the canonical name of PCbuild. Wouldn't be easier to make a replace in the reverse direction?

gronke changed the title globally fix case for PCbuild where it was PCBuild bpo-31569: globally fix case for PCbuild where it was PCBuild Sep 24, 2017
Copy link
Contributor Author

gronke commented Sep 24, 2017

File systems on Windows are case-insensitive. It is not clear what is the canonical name of PCbuild. Wouldn't be easier to make a replace in the reverse direction?

The directory was called PCbuild since 2.7, so I guess PCBuild is a typo that was never noticed because it was never an issue on case-insensitive filesystems.

zooba approved these changes Sep 25, 2017
View changes
pfmoore merged commit f1502d0 into python:master Sep 25, 2017
gronke deleted the correct-PCbuild-typo branch Sep 25, 2017
Copy link
Contributor

josephshen commented Nov 13, 2017

this bug happened and I think it's need port back to all affected version.
it happens when try to compile on on a VM's mapped host filesystem ( e.g. host macOS with case-sensetive filesystem and client Windows)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

zooba

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants