[proxy] web.archive.org — ← back | site home | direct (HTTPS) ↗ | proxy home | ◑ dark◐ light
/ cpython Public

bpo-19865: ctypes.create_unicode_buffer() fails on non-BMP strings on Windows #14081

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 14, 2019
Merged

bpo-19865: ctypes.create_unicode_buffer() fails on non-BMP strings on Windows #14081

merged 2 commits into from
Jun 14, 2019

Conversation

Copy link
Contributor

ZackerySpytz commented Jun 14, 2019 •
edited by bedevere-bot
Loading

The unit test is based on some of the tests in test_unicode.py that check for sizeof(c_wchar) == 2.

https://bugs.python.org/issue19865

vstinner requested changes Jun 14, 2019
View reviewed changes
Copy link

bedevere-bot commented Jun 14, 2019

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

Copy link
Contributor Author

ZackerySpytz commented Jun 14, 2019

Thank you, @vstinner, for the review.

I have made the requested changes; please review again.

Copy link

bedevere-bot commented Jun 14, 2019

Thanks for making the requested changes!

@vstinner: please review the changes made to this pull request.

vstinner merged commit 9765efc into python:master Jun 14, 2019
Copy link
Contributor

miss-islington commented Jun 14, 2019

Thanks @ZackerySpytz for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

Copy link
Contributor

miss-islington commented Jun 14, 2019

Thanks @ZackerySpytz for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

Copy link

bedevere-bot commented Jun 14, 2019

GH-14087 is a backport of this pull request to the 3.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 14, 2019
bpo-19865: ctypes.create_unicode_buffer() supports non-BMP strings on…
5790901 
… Windows (pythonGH-14081)

(cherry picked from commit 9765efc)

Co-authored-by: Zackery Spytz <zspytz@gmail.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 14, 2019
bpo-19865: ctypes.create_unicode_buffer() supports non-BMP strings on…
8d363f9 
… Windows (pythonGH-14081)

(cherry picked from commit 9765efc)

Co-authored-by: Zackery Spytz <zspytz@gmail.com>
Copy link

bedevere-bot commented Jun 14, 2019

GH-14088 is a backport of this pull request to the 3.8 branch.

miss-islington added a commit that referenced this pull request Jun 14, 2019
bpo-19865: ctypes.create_unicode_buffer() supports non-BMP strings on…
0b592d5 
… Windows (GH-14081)

(cherry picked from commit 9765efc)

Co-authored-by: Zackery Spytz <zspytz@gmail.com>
miss-islington added a commit that referenced this pull request Jun 14, 2019
bpo-19865: ctypes.create_unicode_buffer() supports non-BMP strings on…
b0f6fa8 
… Windows (GH-14081)

(cherry picked from commit 9765efc)

Co-authored-by: Zackery Spytz <zspytz@gmail.com>
lisroach pushed a commit to lisroach/cpython that referenced this pull request Sep 10, 2019
bpo-19865: ctypes.create_unicode_buffer() supports non-BMP strings on…
e618b42 
… Windows (pythonGH-14081)
DinoV pushed a commit to DinoV/cpython that referenced this pull request Jan 14, 2020
bpo-19865: ctypes.create_unicode_buffer() supports non-BMP strings on…
12471b1 
… Windows (pythonGH-14081)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

vstinner vstinner requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants