[proxy] web.archive.org — ← back | site home | direct (HTTPS) ↗ | proxy home | ◑ dark◐ light
/ cpython Public
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-34424: Handle different policy.linesep lengths correctly. #8803

Merged
merged 3 commits into from May 14, 2019
Merged

bpo-34424: Handle different policy.linesep lengths correctly. #8803

merged 3 commits into from May 14, 2019

Conversation

Copy link
Contributor

jenstroeger commented Aug 18, 2018 •
edited by bedevere-bot

jenstroeger requested a review from a team as a code owner Aug 18, 2018
Copy link

the-knights-who-say-ni commented Aug 18, 2018

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA (this might be simply due to a missing "GitHub Name" entry in your b.p.o account settings). This is necessary for legal reasons before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for your contribution, we look forward to reviewing it!

Copy link
Contributor Author

jenstroeger commented Aug 29, 2018 •
edited

I did sign the PSF contributor agreement (CLA), so that label should be ok to be removed. Also, since this is a blocking issue on our system: can somebody please review?

jenstroeger commented Aug 29, 2018
View changes
Lib/email/_header_value_parser.py Outdated Show resolved Hide resolved
bitdancer requested changes Oct 19, 2018
View changes
Copy link
Member

bitdancer left a comment

Fix and test look good in general. For unit test completeness it would be nice to add a header_value_parser test for this as well, but I don't think it is that important for this particular issue.

Lib/email/_header_value_parser.py Outdated Show resolved Hide resolved
Lib/test/test_email/test_generator.py Outdated Show resolved Hide resolved
Misc/NEWS.d/next/Library/2018-08-18-14-47-00.bpo-34424.wAlRuS.rst Outdated Show resolved Hide resolved
Copy link

bedevere-bot commented Oct 19, 2018

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

Copy link
Contributor Author

jenstroeger commented Oct 24, 2018 •
edited

I have made the requested changes; please review again.

Also, as a side note, I’ve been running the proposed change for a while now in a live production environment without further issues.

Copy link

bedevere-bot commented Oct 24, 2018

Thanks for making the requested changes!

@bitdancer: please review the changes made to this pull request.

Copy link
Contributor Author

jenstroeger commented Dec 18, 2018

@bitdancer, any update on this? We could really need this change in mainstream as this is critical for our production servers. Thanks!

Copy link
Contributor Author

jenstroeger commented Feb 11, 2019

@bitdancer, a friendly poke… could this please be merged?

csabella requested review from bitdancer and warsaw May 13, 2019
bitdancer merged commit 45b2f88 into python:master May 14, 2019
Copy link

bedevere-bot commented May 14, 2019

@bitdancer: Please replace # with GH- in the commit message next time. Thanks!

Copy link
Contributor

miss-islington commented May 14, 2019

Thanks @jenstroeger for the PR, and @bitdancer for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 14, 2019
bpo-34424: Handle different policy.linesep lengths correctly. (python…
084c9a1 
…GH-8803)

(cherry picked from commit 45b2f88)

Co-authored-by: Jens Troeger <jenstroeger@users.noreply.github.com>
Copy link

bedevere-bot commented May 14, 2019

GH-13302 is a backport of this pull request to the 3.7 branch.

Copy link
Contributor

csabella commented May 14, 2019

@jenstroeger Thank you for the contribution! 🎉 🎉
@bitdancer Thank you for the review and merge!

miss-islington added a commit that referenced this pull request May 14, 2019
bpo-34424: Handle different policy.linesep lengths correctly. (GH-8803)
c0abd0c 
(cherry picked from commit 45b2f88)

Co-authored-by: Jens Troeger <jenstroeger@users.noreply.github.com>
Copy link

Julien00859 commented Oct 29, 2019

The problem is also affecting latest python 3.6, could it be possible to backport it there ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

bitdancer

warsaw

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants