[proxy] web.archive.org — ← back | site home | direct (HTTPS) ↗ | proxy home | ◑ dark◐ light
/ cpython Public
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-29602: fix signed zero handling in complex constructor. #203

Merged
merged 2 commits into from Feb 20, 2017
Merged

bpo-29602: fix signed zero handling in complex constructor. #203

merged 2 commits into from Feb 20, 2017

Conversation

Copy link
Member

mdickinson commented Feb 20, 2017 •
edited

This PR, based on a patch by Serhiy Storchaka, fixes the issues with signed zeros identified in http://bugs.python.org/issue29602:

  • given a class class A(object) implementing __complex__, complex(A()) ignored the sign of a negative zero in the imaginary part
  • given a subclass class C(complex), construction of a C instance from a complex instance also ignored the sign of a negative zero in the imaginary part.

mdickinson added type-bug An unexpected behavior, bug, or error needs backport to 2.7 labels Feb 20, 2017
mdickinson merged commit 112ec38 into python:master Feb 20, 2017
mdickinson deleted the fix/complex-subclass-zeros branch Feb 20, 2017
mdickinson mentioned this pull request Feb 20, 2017
Merged
mdickinson added a commit to mdickinson/cpython that referenced this pull request Feb 20, 2017
bpo-29602: fix signed zero handling in complex constructor. (python#203)
427dcc9 
* Fix incorrect handling of signed zeros for complex-related classes.

* Add Misc/NEWS entry.

(cherry picked from commit 112ec38)
mdickinson added a commit to mdickinson/cpython that referenced this pull request Feb 20, 2017
bpo-29602: fix signed zero handling in complex constructor. (python#203)
ca7fcf4 
* Fix incorrect handling of signed zeros for complex-related classes.

* Add Misc/NEWS entry.

(cherry picked from commit 112ec38)
This was referenced Feb 20, 2017
Merged
Merged
mdickinson added a commit that referenced this pull request Feb 20, 2017
bpo-29602: fix signed zero handling in complex constructor. (#203) (#205
0936a00 
)

* Fix incorrect handling of signed zeros for complex-related classes.

* Add Misc/NEWS entry.

(cherry picked from commit 112ec38)
mdickinson added a commit that referenced this pull request Feb 20, 2017
bpo-29602: fix signed zero handling in complex constructor. (#203) (#206
d9b3cdd 
)

* Fix incorrect handling of signed zeros for complex-related classes.

* Add Misc/NEWS entry.

(cherry picked from commit 112ec38)
akruis pushed a commit to akruis/cpython that referenced this pull request Jan 6, 2019
Stackless issue python#203: use the macro _PyStackless_TRY_STACKLESS
f6dfdea 
instead of _PyRuntime.st.try_stackless.
akruis pushed a commit to akruis/cpython that referenced this pull request Jan 12, 2019
Stackless issue python#203: use the macro _PyStackless_TRY_STACKLESS
60f321a 
instead of _PyRuntime.st.try_stackless.
jaraco pushed a commit that referenced this pull request Dec 2, 2022
Update cherry_picker from 1.2.1 to 1.2.2 (#203)
158701a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

serhiy-storchaka

Assignees
No one assigned
Labels
type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants