[proxy] web.archive.org — ← back | site home | direct (HTTPS) ↗ | proxy home | ◑ dark◐ light
/ cpython Public
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-36783: Added C API Documentation for Time_FromTimeAndFold and PyDateTime_FromDateAndTimeAndFold #13147

Merged
merged 5 commits into from May 7, 2019
Merged

bpo-36783: Added C API Documentation for Time_FromTimeAndFold and PyDateTime_FromDateAndTimeAndFold #13147

merged 5 commits into from May 7, 2019

Conversation

Copy link
Sponsor Contributor

edison12a commented May 7, 2019 •
edited by bedevere-bot

bedevere-bot added docs Documentation in the Doc dir awaiting review labels May 7, 2019
Copy link
Sponsor Contributor Author

edison12a commented May 7, 2019

@pganssle @Mariatta
I have added the requested documentation. Please review.

Copy link

mariatta-bot commented May 7, 2019

Mariatta was mentioned, but she's out of open source from March 18th to May 9th, 2019 . Be aware she might not get to this until after PyCon US.
(I'm a bot)

Copy link
Member

pganssle commented May 7, 2019

This can be backported to at least 3.7.

csabella approved these changes May 7, 2019
View changes
Copy link
Contributor

csabella left a comment

LGTM.

csabella merged commit 5765ecf into python:master May 7, 2019
Copy link
Contributor

miss-islington commented May 7, 2019

Thanks @SimiCode for the PR, and @csabella for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 7, 2019
bpo-36783: Added C API Documentation for Time_FromTimeAndFold and PyD…
fde2574 
…ateTime_FromDateAndTimeAndFold (pythonGH-13147)

(cherry picked from commit 5765ecf)

Co-authored-by: Edison A <20975616+SimiCode@users.noreply.github.com>
Copy link

bedevere-bot commented May 7, 2019

GH-13156 is a backport of this pull request to the 3.7 branch.

miss-islington added a commit that referenced this pull request May 7, 2019
bpo-36783: Added C API Documentation for Time_FromTimeAndFold and PyD…
146010e 
…ateTime_FromDateAndTimeAndFold (GH-13147)

(cherry picked from commit 5765ecf)

Co-authored-by: Edison A <20975616+SimiCode@users.noreply.github.com>
Copy link

SidhdhARTH commented May 28, 2019

Thanks for the update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

csabella

Assignees
No one assigned
Labels
docs Documentation in the Doc dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants