[proxy] web.archive.org — ← back | site home | direct (HTTPS) ↗ | proxy home | ◑ dark◐ light
/ cpython Public
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-36783: Add new references for C API Documentation changes #13204

Merged
merged 4 commits into from May 13, 2019
Merged

bpo-36783: Add new references for C API Documentation changes #13204

merged 4 commits into from May 13, 2019

Conversation

Copy link
Sponsor Contributor

edison12a commented May 8, 2019 •
edited by bedevere-bot

edison12a changed the title Added new references for C API Documentation changes bpo-36783 Added new references for C API Documentation changes May 8, 2019
matrixise reviewed May 8, 2019
View changes
Misc/NEWS.d/next/Documentation/2019-05-08-17-54-02.bpo-36783.Z9b3mL.rst Outdated Show resolved Hide resolved
Doc/c-api/datetime.rst
@@ -106,6 +106,12 @@ Macros to create objects:
.. versionadded:: 3.6


.. c:function:: PyObject* PyTime_FromTime(int hour, int minute, int second, int usecond)
Copy link
Member

matrixise May 8, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do you move this paragraph?

Copy link
Sponsor Contributor Author

edison12a May 8, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I moved that paragraph to create a better order as requested by @pganssle so that PyTime_FromTimeAndFold follows PyTime_FromTime which is a better order for a user who will be reading the docs.

pganssle reviewed May 8, 2019
View changes
Misc/NEWS.d/next/Documentation/2019-05-08-17-54-02.bpo-36783.Z9b3mL.rst Outdated
@@ -0,0 +1 @@
Add new references for C API Documentationadditions of Time_FromTimeAndFold and PyDateTime_FromDateAndTimeAndFold. Patch by Edison Abahurire.
Copy link
Member

pganssle May 8, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would remove this blurb. @matrixise or someone can just add the "skip news" label, but this is just a fixup from the previous PR, which was merged a bit prematurely.

Copy link
Sponsor Contributor Author

edison12a May 8, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @pganssle
I have removed the blurb. Please review the change.
@matrixise

pganssle approved these changes May 8, 2019
View changes
Copy link
Member

pganssle left a comment

LGTM, thanks Edison!

Copy link
Member

pganssle commented May 8, 2019 •
edited

@matrixise @csabella Do one of you mind adding the "skip news" label? This is a fixup for the earlier PR, so it already has a corresponding blurb.

matrixise approved these changes May 13, 2019
View changes
Copy link
Member

matrixise left a comment

Thank you for your contribution

matrixise changed the title bpo-36783 Added new references for C API Documentation changes bpo-36783: Add new references for C API Documentation changes May 13, 2019
matrixise merged commit d28772a into python:master May 13, 2019
Copy link
Member

pganssle commented May 13, 2019

@matrixise This needs a backport to Python 3.7 as well.

Copy link
Member

pganssle commented May 19, 2019

Ping @matrixise or @csabella - is it too late to add the "needs backport" label? The original change that this is a fixup for was backported to 3.7, but this PR wasn't.

Copy link
Contributor

miss-islington commented May 19, 2019

Thanks @SimiCode for the PR, and @matrixise for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 19, 2019
bpo-36783: Add new references for C API Documentation changes (python…
00b8388 
…GH-13204)

(cherry picked from commit d28772a)

Co-authored-by: Edison A <20975616+SimiCode@users.noreply.github.com>
Copy link

bedevere-bot commented May 19, 2019

GH-13413 is a backport of this pull request to the 3.7 branch.

miss-islington added a commit that referenced this pull request May 19, 2019
bpo-36783: Add new references for C API Documentation changes (GH-13204)
951b161 
(cherry picked from commit d28772a)

Co-authored-by: Edison A <20975616+SimiCode@users.noreply.github.com>
edison12a deleted the fixup-bpo-36783 branch Jun 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

matrixise

pganssle

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants