[proxy] web.archive.org — ← back | site home | direct (HTTPS) ↗ | proxy home | ◑ dark◐ light
/ cpython Public
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-39075: types.SimpleNamespace no longer sorts attributes in its repr #19430

Merged
merged 3 commits into from May 16, 2020
Merged

bpo-39075: types.SimpleNamespace no longer sorts attributes in its repr #19430

merged 3 commits into from May 16, 2020

Conversation

Copy link
Contributor

ZackerySpytz commented Apr 8, 2020 •
edited by miss-islington

CuriousLearner reviewed Apr 18, 2020
View changes
Copy link
Member

CuriousLearner left a comment

Just a minor comment. Overall the changes look okay to me.

Doc/library/types.rst Outdated Show resolved Hide resolved
ericsnowcurrently requested changes May 12, 2020
View changes
Copy link
Member

ericsnowcurrently left a comment

Mostly LGTM.

I left a few comments about phrasing in the docs and NEWS entry.

Doc/library/types.rst Outdated Show resolved Hide resolved
Doc/library/types.rst Outdated Show resolved Hide resolved
Misc/NEWS.d/next/Library/2020-04-07-23-44-06.bpo-39075.hgck3j.rst Outdated Show resolved Hide resolved
Copy link

bedevere-bot commented May 12, 2020

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

Copy link
Contributor Author

ZackerySpytz commented May 13, 2020

I have made the requested changes; please review again.

Copy link

bedevere-bot commented May 13, 2020

Thanks for making the requested changes!

@ericsnowcurrently: please review the changes made to this pull request.

CuriousLearner approved these changes May 13, 2020
View changes
Copy link
Member

CuriousLearner left a comment

LGTM 🌮

ericsnowcurrently approved these changes May 16, 2020
View changes
Copy link
Member

ericsnowcurrently left a comment

Thanks for working on this. LGTM

ericsnowcurrently added the 🤖 automerge PR will be merged once it's been approved and all CI passed label May 16, 2020
miss-islington merged commit 6b6092f into python:master May 16, 2020
4 checks passed
arturoescaip pushed a commit to arturoescaip/cpython that referenced this pull request May 24, 2020
bpo-39075: types.SimpleNamespace no longer sorts attributes in its re…
00a75c1 
…pr (pythonGH-19430)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

tirkarthi

ericsnowcurrently

CuriousLearner

Assignees
No one assigned
Labels
🤖 automerge PR will be merged once it's been approved and all CI passed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants