[proxy] web.archive.org — ← back | site home | direct (HTTPS) ↗ | proxy home | ◑ dark◐ light
/ cpython Public
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-41252: Fix incorrect refcounting in _ssl.c's _servername_callback() #21407

Merged
merged 1 commit into from Jul 9, 2020
Merged

bpo-41252: Fix incorrect refcounting in _ssl.c's _servername_callback() #21407

merged 1 commit into from Jul 9, 2020

Conversation

Copy link
Contributor

ZackerySpytz commented Jul 9, 2020 •
edited by miss-islington

https://bugs.python.org/issue41252

Automerge-Triggered-By: @tiran

ZackerySpytz requested a review from tiran as a code owner Jul 9, 2020
tiran approved these changes Jul 9, 2020
View changes
Copy link
Member

tiran left a comment

Good catch!

tiran added the 🤖 automerge PR will be merged once it's been approved and all CI passed label Jul 9, 2020
miss-islington merged commit ee96f32 into python:master Jul 9, 2020
4 checks passed
Copy link
Contributor

miss-islington commented Jul 9, 2020

Thanks @ZackerySpytz for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8, 3.9.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 9, 2020
bpo-41252: Fix incorrect refcounting in _ssl.c's _servername_callback…
a354818 
…() (pythonGH-21407)

(cherry picked from commit ee96f32)

Co-authored-by: Zackery Spytz <zspytz@gmail.com>
Copy link

bedevere-bot commented Jul 9, 2020

GH-21410 is a backport of this pull request to the 3.9 branch.

Copy link

bedevere-bot commented Jul 9, 2020

GH-21411 is a backport of this pull request to the 3.8 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 9, 2020
bpo-41252: Fix incorrect refcounting in _ssl.c's _servername_callback…
89a9263 
…() (pythonGH-21407)

(cherry picked from commit ee96f32)

Co-authored-by: Zackery Spytz <zspytz@gmail.com>
miss-islington added a commit that referenced this pull request Jul 9, 2020
bpo-41252: Fix incorrect refcounting in _ssl.c's _servername_callback…
54babbe 
…() (GH-21407)

(cherry picked from commit ee96f32)

Co-authored-by: Zackery Spytz <zspytz@gmail.com>
miss-islington added a commit that referenced this pull request Jul 9, 2020
bpo-41252: Fix incorrect refcounting in _ssl.c's _servername_callback…
90584c0 
…() (GH-21407)

(cherry picked from commit ee96f32)

Co-authored-by: Zackery Spytz <zspytz@gmail.com>
arun-mani-j pushed a commit to arun-mani-j/cpython that referenced this pull request Jul 21, 2020
bpo-41252: Fix incorrect refcounting in _ssl.c's _servername_callback…
69c7174 
…() (pythonGH-21407)
shihai1991 pushed a commit to shihai1991/cpython that referenced this pull request Aug 20, 2020
bpo-41252: Fix incorrect refcounting in _ssl.c's _servername_callback…
e8e8414 
…() (pythonGH-21407)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

tiran

Assignees
No one assigned
Labels
🤖 automerge PR will be merged once it's been approved and all CI passed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants