Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
While English does in general suggest that trailing punctuation should go inside quotation marks (although I've never personally understood that guideline), in this case it should definitely be outside, as what's inside is expected to be a Python expression, not English text.
| @@ -827,7 +827,7 @@ binary_op(PyObject *v, PyObject *w, const int op_slot, const char *op_name) | |||
| PyErr_Format(PyExc_TypeError, | |||
| "unsupported operand type(s) for %.100s: " | |||
| "'%.100s' and '%.100s'. Did you mean \"print(<message>, " | |||
| "file=<output_stream>)\"", | |||
| "file=<output_stream>)?\"", | |||
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
The question mark should be outside the quote marks, since it isn't part of the suggested Python code.
|
A Python core developer, ncoghlan, has requested some changes be Once you have made the requested changes, please leave a comment |
|
I didn't expect the Spanish Inquisition! |
|
Nobody expects the Spanish Inquisition! @ncoghlan: please review the changes made to this pull request. |
|
Thanks @ncoghlan :) |
Addresses the minor fixes for PR #2345
cc @ncoghlan
https://bugs.python.org/issue30721