[proxy] web.archive.org← back | site home | direct (HTTPS) ↗ | proxy home | ◑ dark◐ light

/ cpython Public

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-33932: Calling Py_Initialize() twice does nothing #7845

Merged
merged 2 commits into from Jun 22, 2018

Conversation

Copy link
Member

vstinner commented Jun 21, 2018

Calling Py_Initialize() twice does nothing, instead of failing with a
fatal error: restore the Python 3.6 behaviour.

https://bugs.python.org/issue33932

Calling Py_Initialize() twice does nothing, instead of failing with a
fatal error: restore the Python 3.6 behaviour.
Exit early if Python is already initialized. Revert my previous
change in _Py_InitializeCore().
Copy link
Member Author

vstinner commented Jun 21, 2018

Oops, I didn't ran the test before pushing. Shame on my. It should be better with the second commit :-)

Copy link
Member Author

vstinner commented Jun 22, 2018

@serhiy-storchaka: Would you mind to have a look at this change? It seems to fix a regression introduced in Python 3.7: https://bugs.python.org/issue33932

I'm not sure that it has been made on purpose. At least, it broke an application in the wild...

vstinner merged commit 209abf7 into python:master Jun 22, 2018
9 checks passed
Copy link
Contributor

miss-islington commented Jun 22, 2018

Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒🤖

Copy link

bedevere-bot commented Jun 22, 2018

GH-7859 is a backport of this pull request to the 3.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this issue Jun 22, 2018
Calling Py_Initialize() twice does nothing, instead of failing with a
fatal error: restore the Python 3.6 behaviour.
(cherry picked from commit 209abf7)

Co-authored-by: Victor Stinner <vstinner@redhat.com>
vstinner deleted the py_init branch Jun 22, 2018
miss-islington added a commit that referenced this issue Jun 22, 2018
Calling Py_Initialize() twice does nothing, instead of failing with a
fatal error: restore the Python 3.6 behaviour.
(cherry picked from commit 209abf7)

Co-authored-by: Victor Stinner <vstinner@redhat.com>
ned-deily pushed a commit to ned-deily/cpython that referenced this issue Jun 27, 2018
Calling Py_Initialize() twice does nothing, instead of failing with a
fatal error: restore the Python 3.6 behaviour.
(cherry picked from commit 209abf7)

Co-authored-by: Victor Stinner <vstinner@redhat.com>
lisroach pushed a commit to lisroach/cpython that referenced this issue Sep 10, 2018
Calling Py_Initialize() twice does nothing, instead of failing with a
fatal error: restore the Python 3.6 behaviour.
yahya-abou-imran pushed a commit to yahya-abou-imran/cpython that referenced this issue Nov 2, 2018
Calling Py_Initialize() twice does nothing, instead of failing with a
fatal error: restore the Python 3.6 behaviour.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants