[proxy] web.archive.org — ← back | site home | direct (HTTPS) ↗ | proxy home | ◑ dark◐ light
/ cpython Public
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-33418: Add tp_clear for function object #8058

Merged
merged 1 commit into from Jul 4, 2018
Merged

bpo-33418: Add tp_clear for function object #8058

merged 1 commit into from Jul 4, 2018

Conversation

Copy link
Member

methane commented Jul 3, 2018 •
edited by bedevere-bot

Without tp_clear, GC can't break cyclic reference.
It will cause memory leak when cyclic reference is
created intentionally.

https://bugs.python.org/issue33418

methane added type-bug An unexpected behavior, bug, or error needs backport to 3.6 needs backport to 3.7 labels Jul 3, 2018
bpo-33418: Add tp_clear for function object
fd8f66c 
Without tp_clear, GC can't break cyclic reference.
It will cause memory leak when cyclic reference is
created intentionally.
Copy link
Member

serhiy-storchaka commented Jul 3, 2018

I have doubts about backporting this change. This can expose bugs when a ref cycle be broken at unexpected place.

methane merged commit 3c45240 into python:master Jul 4, 2018
yahya-abou-imran pushed a commit to yahya-abou-imran/cpython that referenced this pull request Nov 2, 2018
bpo-33418: Add tp_clear for function object (pythonGH-8058)
fdf53d6 
Without tp_clear, GC can't break cyclic reference.
It will cause memory leak when cyclic reference is
created intentionally.
methane deleted the func_clear branch Feb 28, 2019
vstinner added a commit to vstinner/cpython that referenced this pull request Sep 10, 2019
Revert "bpo-33418: Add tp_clear for function object (pythonGH-8058)"
ffacae8 
This reverts commit 3c45240.
Yhg1s pushed a commit that referenced this pull request Sep 10, 2019
Revert "bpo-33418: Add tp_clear for function object (GH-8058)" (GH-15826
ccaea52 
)

This reverts commit 3c45240.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

serhiy-storchaka

Assignees
No one assigned
Labels
type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants