[proxy] web.archive.org — ← back | site home | direct (HTTPS) ↗ | proxy home | ◑ dark◐ light
/ cpython Public
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-40091: Fix a hang at fork in the logging module #19416

Merged
merged 1 commit into from Apr 13, 2020
Merged

bpo-40091: Fix a hang at fork in the logging module #19416

merged 1 commit into from Apr 13, 2020

Conversation

Copy link
Member

vstinner commented Apr 7, 2020 •
edited by bedevere-bot

Fix a hang at fork in the logging module: the new private
_at_fork_reinit() method is now used to reinitialize locks at fork in
the child process.

The createLock() method is no longer used at fork.

https://bugs.python.org/issue40091

bpo-40091: Fix a hang at fork in the logging module
f2fc412 
Fix a hang at fork in the logging module: the new private
_at_fork_reinit() method is now used to reinitialize locks at fork in
the child process.

The createLock() method is no longer used at fork.
vstinner requested a review from vsajip as a code owner Apr 7, 2020
vstinner mentioned this pull request Apr 7, 2020
Closed
Copy link
Member Author

vstinner commented Apr 7, 2020

@vsajip, @gpshead: Would you mind to review this change?

vsajip added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Apr 11, 2020
Copy link

bedevere-bot commented Apr 11, 2020

🤖 New build scheduled with the buildbot fleet by @vsajip for commit f2fc412 🤖

If you want to schedule another build, you need to add the "🔨 test-with-buildbots" label again.

bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Apr 11, 2020
vsajip approved these changes Apr 12, 2020
View changes
Copy link
Member

vsajip left a comment

Looks OK to me, but I'll add gps as a reviewer in case he spots anything.

vsajip requested a review from gpshead Apr 12, 2020
vstinner merged commit 4c3da78 into python:master Apr 13, 2020
vstinner deleted the logging_atfork_reinit branch Apr 13, 2020
Copy link
Member Author

vstinner commented Apr 13, 2020

@gpshead: Your request is still welcomed!

I merged this PR since test_threading is still crashing randomly on AIX which spams my inbox :-) Recent example: https://buildbot.python.org/all/#builders/227/builds/628

If more changes are required, we can still adjust the code later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

vsajip

gpshead

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants