[proxy] web.archive.org — ← back | site home | direct (HTTPS) ↗ | proxy home | ◑ dark◐ light
/ cpython Public
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-36641: Add "const" to PyDoc_VAR macro #12854

Merged
merged 6 commits into from Apr 16, 2019
Merged

bpo-36641: Add "const" to PyDoc_VAR macro #12854

merged 6 commits into from Apr 16, 2019

Conversation

Copy link
Member

methane commented Apr 16, 2019 •
edited by bedevere-bot

methane added 2 commits Apr 16, 2019
bpo-36641: Add "const" to PyDoc_VAR(name) macro
1d10755 
It reduces "data" segment in python about 200KB.
add NEWS entry
cc0e867
serhiy-storchaka reviewed Apr 16, 2019
View changes
Misc/NEWS.d/next/Core and Builtins/2019-04-16-21-18-19.bpo-36641.pz-DIR.rst Outdated
@@ -0,0 +1,2 @@
:c:macro:`PyDoc_VAR(name)` and :c:macro:`PyDoc_STRVAR(name,str)`` now create
Copy link
Member

serhiy-storchaka Apr 16, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be rather in the "C API" section.

Update Misc/NEWS.d/next/C API/2019-04-16-21-18-19.bpo-36641.pz-DIR.rst
a56af9f 
Co-Authored-By: methane <songofacandy@gmail.com>
Copy link
Member

tirkarthi commented Apr 16, 2019

Maybe a naive question does this make any difference in Windows too?

I could see this was suggested in past by @serhiy-storchaka https://bugs.python.org/issue20323#msg236599 .

Copy link

bedevere-bot commented Apr 16, 2019

When you're done making the requested changes, leave the comment: I have made the requested changes; please review again.

vstinner reviewed Apr 16, 2019
View changes
Copy link
Member

vstinner left a comment

LGTM if you fix the NEWS entry.

Update Misc/NEWS.d/next/C API/2019-04-16-21-18-19.bpo-36641.pz-DIR.rst
4ed7078 
Co-Authored-By: methane <songofacandy@gmail.com>
methane merged commit 926b0cb into python:master Apr 16, 2019
methane deleted the const-docstring branch Apr 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

vstinner

serhiy-storchaka

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants