[proxy] web.archive.org — ← back | site home | direct (HTTPS) ↗ | proxy home | ◑ dark◐ light
/ cpython Public

Conversation

Copy link
Contributor

BoboTiG commented Dec 5, 2018 •
edited
Loading

Prevent file descriptor leaks in distutils.

https://bugs.python.org/issue35416

BoboTiG force-pushed the fix-resource-warning-unclosed-file-distutils branch from 2af99ff to bbcfda4 Compare December 5, 2018 14:36
Copy link
Member

merwok commented Dec 20, 2018

Thanks, this looks good!

There are a few instances of weird indentation (from before your patch), I would like to take the opportunity to clean them.

Copy link
Contributor Author

BoboTiG commented Dec 20, 2018

Of course, go ahead :)
Or do you want me to do the clean?

Copy link
Member

merwok commented Dec 20, 2018

Easier if I do them! It could take me a couple weeks though.

Another PR with some of the fixes was just merged, so part of the codebase is already better.

Copy link
Contributor Author

BoboTiG commented Dec 20, 2018 •
edited
Loading

Good :)

methane merged commit 58721a9 into python:master Apr 8, 2019
BoboTiG deleted the fix-resource-warning-unclosed-file-distutils branch April 8, 2019 13:19
merwok reviewed Apr 8, 2019
View reviewed changes
methane mentioned this pull request Apr 9, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

methane methane left review comments

merwok merwok left review comments

serhiy-storchaka serhiy-storchaka approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Comments