[proxy] web.archive.org — ← back | site home | direct (HTTPS) ↗ | proxy home | ◑ dark◐ light
/ cpython Public
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-38210: Remove intersection operation with empty set #16602

Merged
merged 5 commits into from Oct 6, 2019
Merged

bpo-38210: Remove intersection operation with empty set #16602

merged 5 commits into from Oct 6, 2019

Conversation

Copy link
Member

corona10 commented Oct 6, 2019 •
edited by bedevere-bot

There was an unnecessary logic with the empty set.
The logic can be represented by blow code in pure python

result = set() # result = PySet_New(NULL);
it = iter(other)
result.intersection_update(other) 
# result will be empty set and iterator is fully consumed.
# so this logic should be removed

https://bugs.python.org/issue38210

corona10 requested a review from methane as a code owner Oct 6, 2019
corona10 requested a review from serhiy-storchaka Oct 6, 2019
serhiy-storchaka reviewed Oct 6, 2019
View changes
Lib/test/test_dictviews.py Outdated Show resolved Hide resolved
serhiy-storchaka reviewed Oct 6, 2019
View changes
Lib/test/test_dictviews.py Outdated Show resolved Hide resolved
corona10 added the type-bug An unexpected behavior, bug, or error label Oct 6, 2019
serhiy-storchaka merged commit c38e725 into python:master Oct 6, 2019
corona10 deleted the bpo-38210 branch Oct 6, 2019
corona10 mentioned this pull request Oct 8, 2019
Merged
jacobneiltaylor pushed a commit to jacobneiltaylor/cpython that referenced this pull request Dec 5, 2019
bpo-38210: Fix intersection operation with dict view and iterator. (p…
02d3ec2 
…ythonGH-16602)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

serhiy-storchaka

methane

Assignees
No one assigned
Labels
type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants