[proxy] web.archive.org — ← back | site home | direct (HTTPS) ↗ | proxy home | ◑ dark◐ light

/cpython

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-39019: Implement missing __class_getitem__ for SpooledTemporaryFile #17560

Merged
merged 5 commits into from Dec 30, 2019
Merged

bpo-39019: Implement missing __class_getitem__ for SpooledTemporaryFile #17560

merged 5 commits into from Dec 30, 2019
+16 −0

Conversation

Copy link
Contributor

isidentical commented Dec 10, 2019 •
edited by bedevere-bot

https://bugs.python.org/issue39019
bpo-39019: Implement missing __class_getitem__ for SpooledTemporaryFile
Loading status checks…
ea07042
isidentical added 2 commits Dec 25, 2019
divide test call to 2 lines for PEP8
Loading status checks…
81ac8a2
reference with :class:
Loading status checks…
acaf46d
ilevkivskyi reviewed Dec 27, 2019
View changes
Copy link
Contributor

ilevkivskyi left a comment

Thanks! Here are couple comments.
Lib/tempfile.py Show resolved Hide resolved
Misc/NEWS.d/next/Library/2019-12-10-21-11-05.bpo-39019.YIlgZ7.rst Outdated Show resolved Hide resolved
clarify purpose of __class_getitems__
Loading status checks…
5f6343e
isidentical force-pushed the isidentical:bpo-39019-2 branch from fc219b7 to 5f6343e Dec 27, 2019
ilevkivskyi reviewed Dec 27, 2019
View changes
Lib/tempfile.py Outdated Show resolved Hide resolved
clarify the mode
Loading status checks…
d1fa250
ilevkivskyi approved these changes Dec 30, 2019
View changes
Copy link
Contributor

ilevkivskyi left a comment

LGTM!
ilevkivskyi merged commit 09c482f into python:master Dec 30, 2019
9 checks passed
9 checks passed
Docs
Details
Windows (x86)
Details
Windows (x64)
Details
macOS
Details
Ubuntu
Details
Azure Pipelines PR #20191227.18 succeeded
Details
bedevere/issue-number Issue number 39019 found
Details
bedevere/news News entry found in Misc/NEWS.d
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

ZackerySpytz

ilevkivskyi

Assignees
No one assigned
Labels
CLA signed
Projects
None yet
Milestone
No milestone
5 participants