Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
|
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA). CLA MissingOur records indicate the following people have not signed the CLA: For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue. If you have recently signed the CLA, please wait at least one business day You can check yourself to see if the CLA has been received. Thanks again for the contribution, we look forward to reviewing it! |
|
This is my testing code # some_file.py
import urllib.getproxies
print "Hello world!"After running from urllib.request import getproxies
print("Hello world!")I also signed CLA document :) |
f3daaaa
to
cb29251
Compare
|
Please add a NEWS entry : https://devguide.python.org/committing/?highlight=news#what-s-new-and-news-entries . The test looks good to me and the addition seems to be a simple fix too. Thanks. |
|
@tirkarthi I was not able to run I followed the instructions, and looked good, please correct me if I am wrong |
| ("urllib.parse", | ||
| ["quote", "quote_plus", "unquote", "unquote_plus", | ||
| "urlencode", "splitattr", "splithost", "splitnport", | ||
| "splitpasswd", "splitport", "splitquery", "splittag", | ||
| "splittype", "splituser", "splitvalue", ]), | ||
| ("urllib.error", | ||
| ["ContentTooShortError"])], | ||
| "urllib2" : [ | ||
| "urllib2": [ |
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
Please also revert this whitespace change.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
@tirkarthi Done!
| Added support to fix ``getproxies`` in the :mod:`lib2to3.fixes.fix_urllib`. | ||
| module. Patch by José Roberto Meza Cabrera. |
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
| Added support to fix ``getproxies`` in the :mod:`lib2to3.fixes.fix_urllib`. | |
| module. Patch by José Roberto Meza Cabrera. | |
| Added support to fix ``getproxies`` in the :mod:`lib2to3.fixes.fix_urllib` | |
| module. Patch by José Roberto Meza Cabrera. |
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
You are right, Done!
|
Thanks @robertpro for the PR! Buen trabajo! |
|
Congratulations @robertpro! |
|
@pablogsal @pascalin Gracias amigos! |
https://bugs.python.org/issue38080