[proxy] web.archive.org — ← back | site home | direct (HTTPS) ↗ | proxy home | ◑ dark◐ light

/ cpython Public

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-20709: os.utime(path_to_directory): wrong documentation for Windows. #5469

Merged
merged 1 commit into from May 1, 2018
Merged

bpo-20709: os.utime(path_to_directory): wrong documentation for Windows. #5469

merged 1 commit into from May 1, 2018

Conversation

Copy link
Member

matrixise commented Feb 1, 2018 •
edited by bedevere-bot

Remove the paragrah where we explain that os.utime() does not support a
directory as path under Windows.

Co-authored-by: Jan-Philip Gehrcke jgehrcke@gmail.com

https://bugs.python.org/issue20709

csabella reviewed Feb 1, 2018
View changes
Misc/NEWS.d/next/Documentation/2018-02-01-10-57-24.bpo-20709.1flcnc.rst Outdated
@@ -0,0 +1,2 @@
Remove the paragrah where we explain that os.utime() does not support a
directory as path under Windows. Patch by Jan-Philip Gehrcke
Copy link
Contributor

csabella Feb 1, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/paragrah/paragraph

Copy link
Contributor

csabella commented Feb 1, 2018

LGTM, based on the requested change on the ticket.

bpo-20709: os.utime(path_to_directory): wrong documentation for Windows.
14afb25 
Remove the paragraph where we explain that os.utime() does not support a
directory as path under Windows. Patch by Jan-Philip Gehrcke

Co-authored-by: Jan-Philip Gehrcke <jgehrcke@gmail.com>
Copy link
Member Author

matrixise commented Feb 1, 2018

@csabella fixed, based on your Review and I haved fixed the commit message because there was a typo

JulienPalard merged commit 7508a54 into python:master May 1, 2018
4 checks passed
yahya-abou-imran pushed a commit to yahya-abou-imran/cpython that referenced this issue Nov 2, 2018
bpo-20709: os.utime(path_to_directory): wrong documentation for Windo…
77e4a1c 
…ws. (pythonGH-5469)

Remove the paragraph where we explain that os.utime() does not support a
directory as path under Windows. Patch by Jan-Philip Gehrcke

Co-authored-by: Jan-Philip Gehrcke <jgehrcke@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

csabella

Assignees
No one assigned
Labels
CLA signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants