[proxy] web.archive.org — ← back | site home | direct (HTTPS) ↗ | proxy home | ◑ dark◐ light
/ cpython Public
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-34849: Don't log wating for selector.select in asyncio loop iteration #9641

Merged
merged 1 commit into from Sep 30, 2018
Merged

bpo-34849: Don't log wating for selector.select in asyncio loop iteration #9641

merged 1 commit into from Sep 30, 2018

Conversation

Copy link
Contributor

asvetlov commented Sep 30, 2018 •
edited by bedevere-bot

The waiting is pretty normal for any asyncio program, logging its time just adds
a noise to logs without any useful information provided.

https://bugs.python.org/issue34849

Don't log wating for selector.select in asyncio loop iteration. The
41c9e1a 
waiting is pretty normal for any asyncio program, logging its time just adds
a noise to logs without any useful information provided.
asvetlov requested a review from 1st1 as a code owner Sep 30, 2018
asvetlov added the 🤖 automerge PR will be merged once it's been approved and all CI passed label Sep 30, 2018
Copy link
Contributor

miss-islington commented Sep 30, 2018

@asvetlov: Status check is done, and it's a success ✅ .

miss-islington merged commit d5bd036 into python:master Sep 30, 2018
Copy link
Contributor Author

asvetlov commented Sep 30, 2018

@1st1 sorry, I thought @miss-islington requires at least one review approval, the review should be yours.
Unfortunately, bot merged PR just after tests passing.
Could you make a post-review? I'll revert the PR if it is not appropriate.

Copy link
Member

1st1 commented Sep 30, 2018

This pr is fine.

asvetlov deleted the drop-annoying-output branch Oct 1, 2018
yahya-abou-imran pushed a commit to yahya-abou-imran/cpython that referenced this pull request Nov 2, 2018
bpo-34849: Don't log wating for selector.select in asyncio loop itera…
8d70a5e 
…tion (pythonGH-9641)

The waiting is pretty normal for any asyncio program, logging its time just adds
a noise to logs without any useful information provided.



https://bugs.python.org/issue34849
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

1st1

Assignees
No one assigned
Labels
🤖 automerge PR will be merged once it's been approved and all CI passed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants