[proxy] web.archive.org← back | site home | direct (HTTPS) ↗ | proxy home | ◑ dark◐ light
/ cpython Public
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-22872: multiprocessing.Queue's put() and get() now raise ValueError if the queue is closed #9010

Conversation

Copy link
Contributor

ZackerySpytz commented Aug 30, 2018

Previously, put() and get() would raise AssertionError and OSError,
respectively.

https://bugs.python.org/issue22872

…or if the queue is closed

Previously, put() and get() would raise AssertionError and OSError,
respectively.
Copy link

auvipy left a comment

Looks good

def test_closed_queue_put_get_exceptions(self):
for q in multiprocessing.Queue(), multiprocessing.JoinableQueue():
q.close()
for meth, args in (q.put, ('foo',)), (q.get, ()):
Copy link
Member

serhiy-storchaka Oct 12, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would look clearer (and just one line longer) if unroll this loop.

Copy link

bedevere-bot commented Oct 12, 2018

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

serhiy-storchaka merged commit 0461704 into python:master Oct 13, 2018
yahya-abou-imran pushed a commit to yahya-abou-imran/cpython that referenced this pull request Nov 2, 2018
…or if the queue is closed. (pythonGH-9010)

Previously, put() and get() would raise AssertionError and OSError,
respectively.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants