Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
drop isinstance checks from create_subprocess_exec function and let subprocess module do them.
|
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA). Our records indicate we have not received your CLA. For legal reasons we need you to sign this before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue. If you have recently signed the CLA, please wait at least one business day You can check yourself to see if the CLA has been received. Thanks again for your contribution, we look forward to reviewing it! |
| sys.executable, '-c', 'pass', Path('.')) | ||
| await p.wait() | ||
|
|
||
| self.loop.run_until_complete(execute()) |
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
please add self.assertIsNone(loop.run_until_complete(...)) check to emphasize that we checked that the test passed correctly.
| @@ -622,6 +622,18 @@ def test_create_subprocess_shell_text_mode_fails(self): | |||
| self.loop.run_until_complete(execute()) | |||
|
|
|||
|
|
|||
| def test_create_subprocess_exec_with_path(self): | |||
| async def execute(): | |||
| from pathlib import Path | |||
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
Move the import to the top of the module.
Use import pathlib form and pathlib.Path for consistency.
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
|
I have made the requested changes; please review again. BTW the Windows CI errors should be resolved by #5914. |
|
Thanks for making the requested changes! @asvetlov: please review the changes made to this pull request. |
Please take a look on failed test on Windows: https://ci.appveyor.com/project/python/cpython/builds/24869318
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase And if you don't make the requested changes, you will be poked with soft cushions! |
|
Sorry, didn't read your last message. Let's postpone merging for a while. |
| def test_create_subprocess_exec_with_path(self): | ||
| async def execute(): | ||
| p = await subprocess.create_subprocess_exec( | ||
| pathlib.Path(sys.executable), '-c', 'pass') |
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
If we test for the support of the path protocol it is better to use test.support.FakePath instead of pathlib.Path.
#5914 has been merged.
Please sync with master and address @serhiy-storchaka suggestion about test.support.FakePath.
Rebase is not necessary, git merge master is enough. We squash all commits on merging anyway.
|
I have made the requested changes; please review again. |
|
Thanks for making the requested changes! @asvetlov: please review the changes made to this pull request. |
…onGH-13628) Drop isinstance checks from create_subprocess_exec function and let subprocess module do them. https://bugs.python.org/issue35246 https://bugs.python.org/issue35246
Drop isinstance checks from create_subprocess_exec function and let
subprocess module do them.
https://bugs.python.org/issue35246
https://bugs.python.org/issue35246