[proxy] web.archive.org — ← back | site home | direct (HTTPS) ↗ | proxy home | ◑ dark◐ light
/ cpython Public
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-38108: Makes mock objects inherit from Base #16060

Merged
merged 6 commits into from Sep 29, 2019
Merged

bpo-38108: Makes mock objects inherit from Base #16060

merged 6 commits into from Sep 29, 2019

Conversation

Copy link
Contributor

lisroach commented Sep 12, 2019 •
edited

Updates the few Mock classes that do not inherit from Base to properly inherit from base. Updates the super() calls that should go with them as well.

That was all I planned on doing with this diff, but the changes to get AsyncMock inheritance working right with subclasses was so linked with this diff I merged it into one to prevent temporary breaking changes.

https://bugs.python.org/issue38108

lisroach requested a review from voidspace Sep 12, 2019
lisroach closed this Sep 24, 2019
lisroach reopened this Sep 24, 2019
lisroach requested review from ezio-melotti and asvetlov Sep 26, 2019
asvetlov approved these changes Sep 26, 2019
View changes
Copy link
Contributor

asvetlov left a comment •
edited

LGTM

lisroach requested review from gvanrossum, ilevkivskyi, tiran and a team as code owners Sep 27, 2019
Copy link
Contributor Author

lisroach commented Sep 27, 2019

Oops, didn't mean to do that

lisroach removed request for a team, tiran, gvanrossum and ilevkivskyi Sep 27, 2019
lisroach merged commit 9a7d951 into python:master Sep 29, 2019
lisroach deleted the issue38108 branch Sep 29, 2019
Copy link
Contributor

miss-islington commented Sep 29, 2019

Thanks @lisroach for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 29, 2019
bpo-38108: Makes mock objects inherit from Base (pythonGH-16060)
5a75533 
(cherry picked from commit 9a7d951)

Co-authored-by: Lisa Roach <lisaroach14@gmail.com>
Copy link

bedevere-bot commented Sep 29, 2019

GH-16470 is a backport of this pull request to the 3.8 branch.

lisroach pushed a commit that referenced this pull request Sep 30, 2019
bpo-38108: Makes mock objects inherit from Base (GH-16060) (GH-16470)
b76ab35
jacobneiltaylor pushed a commit to jacobneiltaylor/cpython that referenced this pull request Dec 5, 2019
bpo-38108: Makes mock objects inherit from Base (pythonGH-16060)
45359ec
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

asvetlov

voidspace

ezio-melotti

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants